From 1ea7059a20c1e0e43be81f64305ba509e178d4cb Mon Sep 17 00:00:00 2001
From: Kagami Sascha Rosylight <saschanaz@outlook.com>
Date: Sat, 11 Mar 2023 15:08:29 +0100
Subject: [PATCH] fix the syntax

---
 src/general.ts                                    | 5 +++--
 test/oembed/invalid/oembed-too-powerful2.json     | 2 +-
 test/oembed/oembed-allow-safelisted-features.json | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/general.ts b/src/general.ts
index 7a1d2bb..c352498 100644
--- a/src/general.ts
+++ b/src/general.ts
@@ -71,9 +71,10 @@ async function getOEmbedRich($: cheerio.CheerioAPI, pageUrl: string): Promise<OE
 		return null;
 	}
 
-	const allowedFeatures = (iframe.attr('allow') ?? '').split(/\s+/g);
+	// TODO: This implementation only allows basic syntax of `allow`.
+	// Might need to implement better later.
+	const allowedFeatures = (iframe.attr('allow') ?? '').split(/\s*;\s*/g).filter(s => s);
 	const safeList = [
-		'',
 		'autoplay',
 		'clipboard-write',
 		'fullscreen',
diff --git a/test/oembed/invalid/oembed-too-powerful2.json b/test/oembed/invalid/oembed-too-powerful2.json
index c0952dc..312b0e2 100644
--- a/test/oembed/invalid/oembed-too-powerful2.json
+++ b/test/oembed/invalid/oembed-too-powerful2.json
@@ -1,6 +1,6 @@
 {
   "version": "1.0",
   "type": "rich",
-  "html": "<iframe src='https://example.com/' allow='fullscreen camera'></iframe>",
+  "html": "<iframe src='https://example.com/' allow='fullscreen;camera'></iframe>",
   "height": 300
 }
diff --git a/test/oembed/oembed-allow-safelisted-features.json b/test/oembed/oembed-allow-safelisted-features.json
index cfe0ee8..6ef40a1 100644
--- a/test/oembed/oembed-allow-safelisted-features.json
+++ b/test/oembed/oembed-allow-safelisted-features.json
@@ -1,6 +1,6 @@
 {
   "version": "1.0",
   "type": "rich",
-  "html": "<iframe src='https://example.com/' allow='autoplay clipboard-write fullscreen encrypted-media picture-in-picture'></iframe>",
+  "html": "<iframe src='https://example.com/' allow='autoplay;clipboard-write;fullscreen;encrypted-media;picture-in-picture'></iframe>",
   "height": 300
 }