misskey-dev/summaly
1
0
Fork 0
mirror of https://github.com/misskey-dev/summaly.git synced 2025-06-08 12:48:05 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'oembed' into oembed-built

Browse Source
This commit is contained in:
Kagami Sascha Rosylight 2023-03-11 15:09:10 +01:00
commit 51148cea27
3 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/general.ts
View File

@ -71,8 +71,16 @@ async function getOEmbedRich($: cheerio.CheerioAPI, pageUrl: string): Promise<OE
return null; return null;
} }
const allowedFeatures = (iframe.attr('allow') ?? '').split(/\s+/g); // TODO: This implementation only allows basic syntax of `allow`.
const safeList = ['', 'fullscreen', 'encrypted-media', 'picture-in-picture']; // Might need to implement better later.
const allowedFeatures = (iframe.attr('allow') ?? '').split(/\s*;\s*/g).filter(s => s);
const safeList = [
'autoplay',
'clipboard-write',
'fullscreen',
'encrypted-media',
'picture-in-picture'
];
if (allowedFeatures.some(allow => !safeList.includes(allow))) { if (allowedFeatures.some(allow => !safeList.includes(allow))) {
// This iframe is probably too powerful to be embedded // This iframe is probably too powerful to be embedded
return null; return null;

2
test/oembed/invalid/oembed-too-powerful2.json
View File

@ -1,6 +1,6 @@
{ {
"version": "1.0", "version": "1.0",
"type": "rich", "type": "rich",
"html": "<iframe src='https://example.com/' allow='fullscreen camera'></iframe>", "html": "<iframe src='https://example.com/' allow='fullscreen;camera'></iframe>",
"height": 300 "height": 300
} }

2
test/oembed/oembed-allow-safelisted-features.json
View File

@ -1,6 +1,6 @@
{ {
"version": "1.0", "version": "1.0",
"type": "rich", "type": "rich",
"html": "<iframe src='https://example.com/' allow='fullscreen encrypted-media picture-in-picture'></iframe>", "html": "<iframe src='https://example.com/' allow='autoplay;clipboard-write;fullscreen;encrypted-media;picture-in-picture'></iframe>",
"height": 300 "height": 300
} }