From 7a28b44d44d675af5e2cb4e8d46a6853ba300cd4 Mon Sep 17 00:00:00 2001 From: syuilo Date: Mon, 6 Feb 2017 07:00:53 +0900 Subject: [PATCH] Refactor: Move the post logic to each plugins --- src/general.ts | 10 +++++----- src/index.ts | 10 ---------- src/plugins/amazon.ts | 6 +++--- 3 files changed, 8 insertions(+), 18 deletions(-) diff --git a/src/general.ts b/src/general.ts index ea4035b..0a28a3a 100644 --- a/src/general.ts +++ b/src/general.ts @@ -106,10 +106,10 @@ export default async (url: URL.Url): Promise => { } return { - title: title, - icon: icon, - description: description, - thumbnail: image, - sitename: siteName + title: title || null, + icon: icon || null, + description: description || null, + thumbnail: image || null, + sitename: siteName || null }; }; diff --git a/src/index.ts b/src/index.ts index 4270122..80f5fd5 100644 --- a/src/index.ts +++ b/src/index.ts @@ -64,16 +64,6 @@ export default async (url: string, options: Options): Promise => { ? await match.summary(_url) : await general(_url); - // Replace '' to null - Object.keys(summary).forEach(k => { - if (summary[k]) { - summary[k] = summary[k].trim(); - if (summary[k] === '') { - summary[k] = null; - } - } - }); - return Object.assign(summary, { url: actualUrl }); diff --git a/src/plugins/amazon.ts b/src/plugins/amazon.ts index 2684c71..5267518 100644 --- a/src/plugins/amazon.ts +++ b/src/plugins/amazon.ts @@ -34,10 +34,10 @@ export async function summary(url: URL.Url) { const thumbnail: string = $('#landingImage').attr('src'); return { - title: title, + title: title || null, icon: 'https://www.amazon.com/favicon.ico', - description: description, - thumbnail: thumbnail, + description: description || null, + thumbnail: thumbnail || null, sitename: 'Amazon' }; };