2138 Commits

Author	SHA1	Message	Date
Kerwin Bryant	f0f1737d4d	Refactor markup and pdf-viewer to use new init framework (#33772) ... 1. Add some "render-content" classes to "markup" elements when the content is rendered 2. Use correct "markup" wrapper for "preview" (but not set that class on the tab) 3. Remove incorrect "markup" class from LFS file view, because there is no markup content * "edit-diff" is also removed because it does nothing 5. Use "initPdfViewer" for PDF viewer 6. Remove incorrect "content" class from milestone markup 7. Init all ".markup" elements by new init framework --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-03 11:49:15 -08:00
wxiaoguang	27bf63ad20	Refactor global init code and add more comments (#33755) ... Follow up #33748 Now there are 3 "global" functions: * registerGlobalSelectorFunc: for all elements matching the selector, eg: `.ui.dropdown` * registerGlobalInitFunc: for `data-global-init="initInputAutoFocusEnd"` * registerGlobalEventFunc: for `data-global-click="onCommentReactionButtonClick"` And introduce `initGlobalInput` to replace old `initAutoFocusEnd` and `attachDirAuto`, use `data-global-init` to replace fragile `.js-autofocus-end` selector. Another benefit is that by the new approach, no matter how many times `registerGlobalInitFunc` is called, we only need to do one "querySelectorAll" in the last step, it could slightly improve the performance.	2025-03-03 10:57:28 +08:00
wxiaoguang	698ae7aa5b	Fix dynamic content loading init problem (#33748) ... 1. Rewrite `dirauto.ts` to `observer.ts`. * We have been using MutationObserver for long time, it's proven that it is quite performant. * Now we extend its ability to handle more "init" works. 2. Use `observeAddedElement` to init all non-custom "dropdown". 3. Use `data-global-click` to handle click events from dynamically loaded elements. * By this new approach, the old fragile selector-based (`.comment-reaction-button`) mechanism is removed. 4. By the way, remove unused `.diff-box` selector, it was abused and never really used. A lot of FIXMEs in "repo-diff.ts" are completely fixed, newly loaded contents could work as expected.	2025-03-01 02:02:10 +00:00
wxiaoguang	4e56d5f39f	Refactor repo-diff.ts (#33746) ... Remove jQuery	2025-02-28 16:37:16 +08:00
Alexander McRae	aba96f65cd	Use git diff-tree for DiffFileTree on diff pages (#33514) ... Modify Diff View FileTree to show all files ## Changes * removes Show Status button on diff * uses `git diff-tree` to generate the file tree for the diff * doesn't reload the diff tree each time we load more files in the preview * selecting and unloaded file will keep loading until that file is loaded * removes `DiffFileList.vue` and "Show Stats" in diff options ## Open Questions * selecting and unloaded file will keep loading until that file is loaded. Is this behaviour okay? It matches what github does. ### Demo In this demo I set `git.MAX_GIT_DIFF_FILES=1` in my `app.ini` to demonstrate a worst case example. In most cases the behaviour isn't nearly as jarring as we load a bunch of files at a time. https://github.com/user-attachments/assets/72f29663-d6fc-472d-94fa-7fb5950c2836 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-02-28 00:58:25 +00:00
Guillaume	303af554c9	Improve "generate new access token" form (#33730) ... Fix: https://github.com/go-gitea/gitea/issues/33519 As discussed in [PR #33614](https://github.com/go-gitea/gitea/pull/33614), the ScopedAccessTokenSelector Vue component is not particularly useful. This PR removes the component and reverts to using HTML templates. It also introduces some (hopefully) useful refactoring. The Vue component was causing the UX bug reported in the linked issue. Required form fields are now properly working, as expected (see screenshot).  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-02-27 19:40:12 +00:00
Quentin	f52e31f5ce	Clone repository with Tea CLI (#33725) ... This PR adds "Tea CLI" as a clone method. <img width="350" alt="Capture d’écran 2025-02-25 à 23 38 47" src="https://github.com/user-attachments/assets/8e86e54a-998b-45d1-9f20-167b449e79b6" /> --------- Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-02-27 18:18:02 +00:00
Quentin	793c0e1fa6	Align sidebar gears to the right (#33721) ... Currently, the issue/pr sidebar is hard to read visually. One of the reason is that the gear icons make reading difficult because they are "in the way" when reading, and not aligned together. This PR proposes to align them on the right. Actions are also better highlighted this way. ## Screenshots ### Issue | Before this PR | After this PR | | --- | --- | | <img width="322" alt="Capture d’écran 2025-02-25 à 19 59 39" src="https://github.com/user-attachments/assets/efdd13af-7b22-4f2b-8e65-dd17d6f3ffad" /> | <img width="322" alt="Capture d’écran 2025-02-25 à 19 58 56" src="https://github.com/user-attachments/assets/eeacc3f4-5e2c-4558-a4b3-0f1ab4742107" /> | ### Pull Request | Before this PR | After this PR | | --- | --- | | <img width="322" alt="Capture d’écran 2025-02-25 à 20 16 12" src="https://github.com/user-attachments/assets/c274b58b-ad50-4ad8-b3da-91dbabd1b120" /> | <img width="322" alt="Capture d’écran 2025-02-25 à 20 15 54" src="https://github.com/user-attachments/assets/ecfd6d60-a525-4767-872d-2ef84030d81e" /> | Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2025-02-27 00:03:23 +02:00
wxiaoguang	555d64d024	Always show the "rerun" button for action jobs (#33692) ... And improve the mock code.	2025-02-24 08:40:46 +00:00
wxiaoguang	ead716d204	Improve Open-with URL encoding (#33666) ... Fix #33665	2025-02-21 17:46:05 +00:00
wxiaoguang	cd225d7034	Fix mCaptcha bug (#33659) ... Fix #33658	2025-02-20 22:53:38 +08:00
silverwind	1ba7cbbfd6	Fix typo in HTML attribute (#33599)	2025-02-14 10:59:37 -05:00
Kerwin Bryant	085f273d19	Optimize the dashboard (#32990) ... before:  after:  -----  ----- Optimize the dashboard by adding welcoming messages or quick action entry points (such as adding a new repository or organization) to ensure that new users are not greeted by a blank page upon logging in. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-02-11 01:24:34 +08:00
wxiaoguang	06088ec672	Remove "class-name" from svg icon (#33540) ... Only use "class" attribute	2025-02-09 22:39:54 +02:00
Kerwin Bryant	40426addfa	Add cropping support when modifying the user/org/repo avatar (#33498) ... Fixed #33321 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-02-06 21:07:44 +08:00
Typed SIGTERM	47bf836310	Update feishu icon (#33470)	2025-02-01 14:08:32 +00:00
wxiaoguang	1ab5938e82	Hide/disable unusable UI elements when a repository is archived (#33459) ... And by the way, remove some jQuery code	2025-01-31 20:47:31 +08:00
silverwind	05e9063013	Update @github/text-expander-element, adapt type imports (#33449) ... Followup to https://github.com/go-gitea/gitea/pull/33435, upstream issue is fixed so the imports are clean now.	2025-01-31 02:50:18 +00:00
wxiaoguang	b57d9f41d4	Fix issue sidebar dropdown keyboard support (#33447) ... Just a quick fix, fix #33444	2025-01-30 22:54:50 +00:00
silverwind	dc7ddaee2a	Update @github/text-expander-element to 2.9.0 (#33435) ... Update and use their newly exported types. Tested, works. The import path is a bit suboptimal, to be fixed once https://github.com/github/text-expander-element/pull/75 is merged and released. Co-authored-by: Giteabot <teabot@gitea.io>	2025-01-29 23:38:53 +00:00
wxiaoguang	182e3896bf	Fix flex width (#33414) ... Fix #33409	2025-01-27 17:09:20 +00:00
silverwind	9875f9b9b8	Clone button enhancements (#33362) ... - Add box-shadow to default tippy theme - Make colors for tabs match the ones from `.ui.tabular.menu` - Remove tippy arrow and slightly offset tooltip closer to the button - Fix setting of `aria-haspopup` when default role is used with tippy --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-01-27 02:07:29 +08:00
wxiaoguang	e663c4a7f0	Fix issue suggestion bug (#33389) ... Fix #33388	2025-01-26 13:13:32 +00:00
wxiaoguang	6a516a0d14	Do not show unnecessary commit sign lock icon (#33387) ... Fix #33385	2025-01-25 19:32:35 +08:00
wxiaoguang	7da8a01d39	Fix js error when edit issue (#33384)	2025-01-25 09:37:25 +08:00
silverwind	642e8c1122	Repo homepage styling tweaks (#33289) ... Reduce it to a value that results in `.repo-home-sidebar-top` and `.repo-home-sidebar-bottom` having 240px content width, the same as GitHub. Before: <img width="1333" alt="Screenshot 2025-01-15 at 18 28 34" src="https://github.com/user-attachments/assets/cf0fa21b-87be-40e3-a6cd-26d146bce9cc" /> After: <img width="1330" alt="Screenshot 2025-01-15 at 18 28 27" src="https://github.com/user-attachments/assets/28acd837-10f4-4176-b8a0-510cd28c8b8d" />	2025-01-24 17:35:28 +00:00
Typed SIGTERM	9e028d8d57	Fix comment header padding (#33377)	2025-01-25 01:09:57 +08:00
silverwind	c7f4ca2653	Enable Typescript noImplicitAny (#33322) ... Enable `noImplicitAny` and fix all issues. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-01-22 15:11:51 +08:00
wxiaoguang	2cb3946496	Make issue suggestion work for all editors (#33340) ... And do not handle special keys when the text-expander popup exists	2025-01-21 19:33:45 +08:00
Vladimir Sysoev	dc2308a959	Make tracked time representation display as hours (#33315) ... Estimated time represented in hours it might be convenient to have tracked time represented in the same way to be compared and managed. --------- Co-authored-by: Sysoev, Vladimir <i@vsysoev.ru> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-01-19 09:30:44 +08:00
wxiaoguang	3b839f8dc0	Trivial fixes (#33304) ... 1. the error check was added for go-git, it was caused by the empty `.keep` file in the test fixtures. 2. use `PostFormValue` instead of `PostForm.Get` (`Get` needs to parse the form ahead) 3. fix incorrect container text (it should show "Images" in the header but not "OS/Arch") 4. align maven xml 5. fix closed PR color&icon	2025-01-17 08:55:02 +00:00
silverwind	4b21a6c792	Enable Typescript noImplicitThis (#33250) ... - Enable https://www.typescriptlang.org/tsconfig/#noImplicitThis - Wrap Vue Template-Syntax SFCs in [`defineComponent`](https://vuejs.org/api/general#definecomponent) which makes type inference and linter work better - Move `createApp` calls outside the SFCs into separate files - Use [`PropType`](https://vuejs.org/api/utility-types#proptype-t) where appropriate - Some top-level component properties changed order as dictated by the linter - Fix all tsc and lint issues that popped up during these refactors	2025-01-16 04:26:17 +08:00
wxiaoguang	6659a381ea	Fix closed dependency title (#33285) ... Fix #33283	2025-01-15 23:38:03 +08:00
wxiaoguang	c0751ef116	Fix upload file form (#33230) ... Fix #33228	2025-01-13 03:39:15 +08:00
wxiaoguang	9024b79933	Remove unused CSS styles and move some styles to proper files (#33217)	2025-01-12 05:16:22 +00:00
Harry Vince	d7ec23febf	Fix editor markdown not incrementing in a numbered list (#33187) ... Amended the logic for newPrefix in the MarkdownEditor to resolve incorrect number ordering. Fixes #33184 Attached screenshot of fixed input similar to issue <img width="175" alt="Screenshot 2025-01-09 at 23 59 24" src="https://github.com/user-attachments/assets/dfa23cf1-f3db-4b5e-99d2-a71bbcb289a8" /> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-01-10 07:28:38 +00:00
Lunny Xiao	39d51e7c82	Automerge supports deleting branch automatically after merging (#32343) ... Resolve #32341 ~Depends on #27151~ - [x] It will display a checkbox of deleting the head branch on the pull request view page when starting an auto-merge task. - [x] Add permission check before deleting the branch - [x] Add delete branch comment for those closing pull requests because of head branch or base branch was deleted. - [x] Merge `RetargetChildrenOnMerge` and `AddDeletePRBranchComment` into `service.DeleteBranch`.	2025-01-10 03:51:03 +08:00
wxiaoguang	9c00e065a1	Fix form width (#33151) ... Fix #33150	2025-01-08 23:57:18 +08:00
wxiaoguang	386c1ed908	Refactor HTMLFormat, update chroma render, fix js error (#33136) ... A small refactor to improve HTMLFormat, to help to prevent low-level mistakes. And fix #33141, fix #33139	2025-01-08 03:44:32 +00:00
Rowan Bohde	a8e7caedfa	add submodule diff links (#33097) ... This adds links to submodules in diffs, similar to the existing link when viewing a repo at a specific commit. It does this by expanding diff parsing to recognize changes to submodules, and find the specific refs that are added, deleted or changed. Related #25888 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-01-08 01:38:30 +00:00
TheFox0x7	4a18c72262	Remove extended glob pattern from branch protection UI (#33125) ... Underlying go library has no support for it Fixes: https://github.com/go-gitea/gitea/issues/33121 --- I never touched frontend tests so pointers how to write them are welcome. This can be either fix or workaround, depending if this is something gitea should support in the future or not. The golang side is unlikely to get updates though.	2025-01-07 01:23:50 +02:00
wxiaoguang	ef736b7e27	Refactor legacy JS (#33115)	2025-01-06 17:38:42 +08:00
wxiaoguang	cf60734a4d	Fix dropdown menu header and mobile view (#33108) ...  ----  ---- 	2025-01-05 21:20:22 +00:00
wxiaoguang	2b064b8637	Refactor legacy line-number and scroll code (#33094) ... 1. remove jquery 2. rewrite the "line number selection", fix various edge cases 3. fix the scroll	2025-01-04 10:56:07 +08:00
wxiaoguang	68972a9947	Clean up legacy form CSS styles (#33081)	2025-01-03 04:01:19 +00:00
wxiaoguang	c1167709ed	Refactor repo-new.ts (#33070) ... 1. merge `repo-template.ts` into `repo-new.ts` (they are all for "/repo/create") 2. remove jquery 3. fix an anonying fomantic dropdown bug, see the comment of `onResponseKeepSelectedItem`	2025-01-01 17:21:13 +00:00
wxiaoguang	85c756e279	Refactor pull-request compare&create page (#33071) ... The old code is unnecessarily complex.	2025-01-02 01:16:09 +08:00
wxiaoguang	a0853e2278	Fix unittest and repo create bug (#33061) ... 1. `StatDir` was not right, fix the FIXME 2. Clarify the test cases for `IsUsableRepoName` 3. Fix regression bug in `repo-new.ts` Fix #33060	2024-12-31 18:45:05 +08:00
Chai-Shi	0387195abb	[Feature] Private README.md for organization (#32872) ... Implemented #29503 --------- Co-authored-by: Ben Chang <ben_chang@htc.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-12-31 04:22:09 +00:00
wxiaoguang	c09656e0e0	Make issue suggestion work for new PR page (#33035) ... Fix #33026	2024-12-31 03:50:55 +00:00