be2a6b4414
Fix bug when review pull request commits ( #35192 )
...
cron-translations / crowdin-pull (push) Has been skipped
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
The commit range in the UI follows a half-open, half-closed convention:
(,]. When reviewing a range of commits, the beforeCommitID should be set
to the commit immediately preceding the first selected commit. For
single-commit reviews, we must identify and use the previous commit of
that specific commit.
The endpoint ViewPullFilesStartingFromCommit is currently unused and can
be safely removed.
Fix #35157
Replace #35184
Partially extract from #35077
2025-08-03 10:23:10 -07:00
7cc47da78c
Refactor view issue & comment list styles ( #35061 )
...
cron-translations / crowdin-pull (push) Has been skipped
release-nightly / nightly-docker-rootless (push) Has been cancelled
release-nightly / nightly-binary (push) Has been cancelled
release-nightly / nightly-docker-rootful (push) Has been cancelled
Fix #35060
2025-07-13 22:52:35 +08:00
211135b4bb
Fix various problems ( #35012 )
...
* Fix #35011
* Fix incorrect log message for "Protocol"
* Remove unnecessary styles, fix "comment-header" wrap, fix label height
2025-07-09 16:46:51 +00:00
3a37d63d61
Allow renaming/moving binary/LFS files in the UI ( #34350 )
...
Adds the ability to rename/move binary files like binary blobs or images
and files that are too large in the web ui.
This was purposed in #24722 , along with the ability edit images via an
upload of a new image, which I didn't implement here (could be done in a
separate PR).
Binary file content:
File too large:
GitHub does the same (I've copied the text from there):
2025-06-16 17:15:07 -07:00
179068fddb
Refactor commit message rendering and fix bugs ( #34412 )
...
Fix #34398 , fix #33308
Remove all `repo.ComposeCommentMetas` from templates,
only use `repo` to render commit message.
2025-05-09 20:42:35 +08:00
62f73491f3
Use lfs label for lfs file rather than a long description ( #34363 )
...
Before
After
2025-05-05 00:07:29 +03:00
2b76993415
support the open-icon of folder ( #34168 )
...
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-04-28 19:51:32 -07:00
e625250ffc
Fix various trivial frontend problems ( #34263 )
...
1. Fix #20606
2. Fix #34246
3. Fix missing spaces, fix misspells, no visual change.
4. Fix missing "not-mobile", fix #34265
---------
Co-authored-by: silverwind <me@silverwind.io >
2025-04-24 09:11:54 +08:00
714245844f
Update compare.tmpl ( #34251 )
...
before:
after:
2025-04-21 23:14:38 +00:00
c9aa9068b3
Fix various UI problems ( #34243 )
...
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
release-nightly / nightly-binary (push) Waiting to run
Also fix #34242
2025-04-19 08:43:22 +00:00
dd0caf7e16
Fix various misalignments and overflows ( #34227 )
...
cron-translations / crowdin-pull (push) Has been skipped
release-nightly / nightly-docker-rootful (push) Has been cancelled
release-nightly / nightly-docker-rootless (push) Has been cancelled
release-nightly / nightly-binary (push) Has been cancelled
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-04-17 10:32:41 +00:00
bde014e46d
Fix button alignments and remove unnecessary styles ( #34206 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
cron-translations / crowdin-pull (push) Has been skipped
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-04-16 08:14:10 +00:00
e1c2d05bde
Fix markdown render behaviors ( #34122 )
...
* Fix #27645
* Add config options `MATH_CODE_BLOCK_DETECTION`, problematic syntaxes
are disabled by default
* Fix #33639
* Add config options `RENDER_OPTIONS_*`, old behaviors are kept
2025-04-05 11:56:48 +08:00
b1e326d09e
Auto expand "New PR" form ( #33971 )
...
Follow GitHub's behavior: use `?expand=1` to expand the "New PR" form
2025-03-24 14:28:02 +00:00
1ea5216f4a
Replace text-align classes with tailwind ( #33905 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Small refactor to remove these CSS classes in favor of tailwind.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-03-16 12:08:16 +00:00
3f1f808b9e
Full-file syntax highlighting for diff pages ( #33766 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Fix #33358 , fix #21970
This adds a step in the `GitDiffForRender` that does syntax highlighting for the
entire file and then only references lines from that syntax highlighted
code. This allows things like multi-line comments to be syntax
highlighted correctly.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-03-09 12:51:58 +08:00
6422f05a4e
Decouple diff stats query from actual diffing ( #33810 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
The diff stats are no longer part of the diff generation.
Use `GetDiffShortStat` instead to get the total number of changed files,
added lines, and deleted lines.
As such, `gitdiff.GetDiff` can be simplified:
It should not do more than expected.
And do not run "git diff --shortstat" for pull list. Fix #31492
2025-03-08 17:36:08 +08:00
698ae7aa5b
Fix dynamic content loading init problem ( #33748 )
...
1. Rewrite `dirauto.ts` to `observer.ts`.
* We have been using MutationObserver for long time, it's proven that it
is quite performant.
* Now we extend its ability to handle more "init" works.
2. Use `observeAddedElement` to init all non-custom "dropdown".
3. Use `data-global-click` to handle click events from dynamically
loaded elements.
* By this new approach, the old fragile selector-based
(`.comment-reaction-button`) mechanism is removed.
4. By the way, remove unused `.diff-box` selector, it was abused and
never really used.
A lot of FIXMEs in "repo-diff.ts" are completely fixed, newly loaded
contents could work as expected.
2025-03-01 02:02:10 +00:00
aba96f65cd
Use git diff-tree for DiffFileTree on diff pages ( #33514 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
Modify Diff View FileTree to show all files
## Changes
* removes Show Status button on diff
* uses `git diff-tree` to generate the file tree for the diff
* doesn't reload the diff tree each time we load more files in the
preview
* selecting and unloaded file will keep loading until that file is
loaded
* removes `DiffFileList.vue` and "Show Stats" in diff options
## Open Questions
* selecting and unloaded file will keep loading until that file is
loaded. Is this behaviour okay? It matches what github does.
### Demo
In this demo I set `git.MAX_GIT_DIFF_FILES=1` in my `app.ini` to
demonstrate a worst case example. In most cases the behaviour isn't
nearly as jarring as we load a bunch of files at a time.
https://github.com/user-attachments/assets/72f29663-d6fc-472d-94fa-7fb5950c2836
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-02-28 00:58:25 +00:00
1ab5938e82
Hide/disable unusable UI elements when a repository is archived ( #33459 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
cron-translations / crowdin-pull (push) Has been skipped
And by the way, remove some jQuery code
2025-01-31 20:47:31 +08:00
9e028d8d57
Fix comment header padding ( #33377 )
2025-01-25 01:09:57 +08:00
a8e7caedfa
add submodule diff links ( #33097 )
...
This adds links to submodules in diffs, similar to the existing link
when viewing a repo at a specific commit. It does this by expanding diff
parsing to recognize changes to submodules, and find the specific refs
that are added, deleted or changed.
Related #25888
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-01-08 01:38:30 +00:00
85c756e279
Refactor pull-request compare&create page ( #33071 )
...
The old code is unnecessarily complex.
2025-01-02 01:16:09 +08:00
3d3ece36d2
Refactor comment history and fix content edit ( #33018 )
...
And fix a regression bug for comment content editing.
Now 11 "import jquery" files left
2024-12-28 19:26:16 +08:00
079a1ffe8f
De-emphasize signed commits ( #31160 )
...
The new code structure is easier to make more improvements or
refactor, for example: change the colors to de-emphasize more, or design
some new layouts.
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-12-28 04:18:30 +08:00
b7260400f8
Refactor tmpl and blob_excerpt ( #32967 )
...
release-nightly / nightly-binary (push) Waiting to run
release-nightly / nightly-docker-rootful (push) Waiting to run
release-nightly / nightly-docker-rootless (push) Waiting to run
1. do not use `{{/* */}}` to remove spaces, use `{{- -}}`
2. fix "blob_excerpt" endpoint, remove the legacy fragile code: have
tested commit diff and wiki diff
2024-12-25 00:51:13 +08:00
00e2b339b6
Fix "unicode escape" JS error ( #32806 )
...
<details>
</details>
---------
Co-authored-by: silverwind <me@silverwind.io >
2024-12-12 18:37:44 +00:00
c9e582c6b6
Refactor markdown editor and use it for milestone description editor ( #32688 )
...
Refactor markdown editor to clarify its "preview" behavior and remove
jQuery code.
Close #15045
---------
Co-authored-by: silverwind <me@silverwind.io >
2024-12-04 02:11:34 +00:00
2f43536c3e
Fix issue title rendering and refactor legacy function names ( #32703 )
...
Fix #32700 , regression of recent markup refactoring
And by the way, clarify many legacy problems:
1. Some "RenderXxx" functions do not really "render", they only call "post processors"
2. Merge "RenderEmoji | RenderCodeBlock", they are all for "simple issue title"
2024-12-04 01:39:33 +00:00
25cacaf0aa
Fixed Issue of Review Menu Shown Behind ( #32631 )
...
Fixed #31144
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-11-26 09:24:56 +08:00
d11f8d24b0
Add 'Copy path' button to file view ( #32584 )
...
Also adds a tooltip which is replicated to the same button in the diff
box. Fixes: https://github.com/go-gitea/gitea/issues/32583
2024-11-21 04:03:17 +00:00
145e266987
Support quote selected comments to reply ( #32431 )
...
Many existing tests were quite hacky, these could be improved later.
<details>
</details>
2024-11-07 03:57:07 +00:00
4a469c8e1b
Refactor template ctx and render utils ( #32422 )
...
Clean up the templates
2024-11-05 14:04:26 +08:00
b068dbd40e
Refactor DateUtils and merge TimeSince ( #32409 )
...
Follow #32383 and #32402
2024-11-04 11:30:00 +00:00
fec6b3d500
Replace DateTime with DateUtils ( #32383 )
2024-11-02 04:08:28 +00:00
1a811c0bd1
Refactor image diff ( #31444 )
...
And remove some jQuery functions
2024-06-22 04:52:09 +00:00
c60ef946b1
Fix the wrong line number in the diff view page when expanded twice. ( #31431 )
...
close #31149 , regression of #29385 (incorrect `data-query=`)
2024-06-20 17:43:42 +00:00
e6ab6e637f
code optimization ( #31315 )
...
Simplifying complex if-else to existing Iif operations
2024-06-11 21:07:10 +08:00
7034efc7dc
Use vertical layout for multiple code expander buttons ( #31122 )
...
Fixes: https://github.com/go-gitea/gitea/issues/31068
- Now it only does a single call to `GetExpandDirection` per line
instead of multiples.
- Exposed `data-expand-direction` to frontend so it can correctly size
the buttons (it's a pain to do in tables).
<img width="142" alt="Screenshot 2024-05-27 at 20 44 56"
src="https://github.com/go-gitea/gitea/assets/115237/8b0b45a6-8e50-4081-8822-5e0775d8d941 ">
<img width="142" alt="Screenshot 2024-05-27 at 20 44 51"
src="https://github.com/go-gitea/gitea/assets/115237/b7ba2c57-8f55-4e9f-9606-c96d16b77892 ">
<img width="132" alt="Screenshot 2024-05-27 at 20 44 46"
src="https://github.com/go-gitea/gitea/assets/115237/0e838fb8-5e8c-4250-9843-a68b88d5418b ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 33"
src="https://github.com/go-gitea/gitea/assets/115237/da6c7f83-c160-4389-8ab2-889d0568cbe8 ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 26"
src="https://github.com/go-gitea/gitea/assets/115237/cdb490b2-5040-484a-92e5-46fc5e37c199 ">
<img width="78" alt="Screenshot 2024-05-27 at 20 44 20"
src="https://github.com/go-gitea/gitea/assets/115237/d2978ab0-764e-41ff-922c-25f8fe749f28 ">
Would backport as trivial enhancement.
2024-05-29 06:08:45 +00:00
1e3c4d8fc7
Improve mobile review ui ( #31091 )
...
Fixes: https://github.com/go-gitea/gitea/issues/31071
Not perfect but much better than before.
Before: Overflows, sticky not working, filename unreadable:
<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f ">
After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c ">
2024-05-28 13:41:37 +00:00
aa92b13164
Prevent simultaneous editing of comments and issues ( #31053 )
...
fixes #22907
Tested:
- [x] issue content edit
- [x] issue content change tasklist
- [x] pull request content edit
- [x] pull request change tasklist
2024-05-27 15:34:18 +00:00
072b029b33
Simplify review UI ( #31062 )
...
Instead of always displaying all available actions as buttons, merge
them into a single dropdown menu, same as GitHub. That decreases visual
overload and is more mobile-friendly, while not losing any
functionality.
## Screenshots
<details><summary>Before</summary>
</details>
<details><summary>After (unexpanded)</summary>
</details>
<details><summary>After (expanded)</summary>
</details>
2024-05-27 08:24:34 +00:00
f48cc501c4
Fix incorrect "blob excerpt" link when comparing files ( #31013 )
...
When comparing files between the base repo and forked repo, the "blob
excerpt" link should point to the forked repo, because the commit
doesn't exist in base repo.
Co-authored-by: Giteabot <teabot@gitea.io >
2024-05-20 05:57:57 +00:00
8de2992ffb
Make Ctrl+Enter work for issue/comment edit ( #30720 )
...
Fix #30710
2024-04-27 14:32:00 +00:00
dd301cae1c
Prevent allow/reject reviews on merged/closed PRs ( #30686 )
...
Resolves #30675 .
2024-04-27 11:55:03 +00:00
c93eefb42b
Diff color enhancements, add line number background ( #30670 )
...
1. Bring back the background on line numbers. This feature was lost a
long time ago.
<img width="457" alt="Screenshot 2024-04-24 at 01 36 09"
src="https://github.com/go-gitea/gitea/assets/115237/76a7f5a9-c22a-4c72-9f0a-ebf16a66513e ">
<img width="473" alt="Screenshot 2024-04-24 at 01 22 47"
src="https://github.com/go-gitea/gitea/assets/115237/eef06cf2-f1b9-40e3-947d-dd5852ec12a3 ">
<img width="457" alt="Screenshot 2024-04-24 at 02 13 18"
src="https://github.com/go-gitea/gitea/assets/115237/59e317d4-76a7-468c-8a19-10d88c675cc3 ">
<img width="459" alt="Screenshot 2024-04-24 at 01 23 21"
src="https://github.com/go-gitea/gitea/assets/115237/f1a46f8d-8846-4d78-a9d7-8b7dc18ac6e4 ">
2. Expanded lines background is now full-line, including line numbers:
<img width="1303" alt="Screenshot 2024-04-24 at 01 37 12"
src="https://github.com/go-gitea/gitea/assets/115237/271eefe2-0869-424e-93fb-ccd8adc87806 ">
3. Sort affected colors alphabetically in the CSS
Fixes #14603
2024-04-26 19:37:21 +00:00
9946353282
Remove fomantic button module ( #30475 )
...
CSS-only module. Button colors are reduced to this:
<img width="639" alt="Screenshot 2024-04-14 at 15 36 07"
src="https://github.com/go-gitea/gitea/assets/115237/882d6c02-d1de-44f2-b707-db02a9f5070d ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-14 17:53:52 +00:00
4b1063f3db
Rewrite and restyle reaction selector and enable no-sizzle eslint rule ( #30453 )
...
Enable `no-sizzle` lint rule, there was only one use in `initCompReactionSelector` and:
- Remove all jQuery except the necessary fomantic dropdown init
- Remove the recursion, instead bind event listeners to common parent container nodes
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-14 18:44:11 +08:00
50099d7af4
Various improvements for long file and commit names ( #30374 )
...
Fixes: https://github.com/go-gitea/gitea/issues/29438
This contains numerous enhancements for how large commit messages and
large filenames render. Another notable change is that the file path is
no longer cut off by backend at 30 chars, but rendered in full with
wrapping.
<img width="1329" alt="Screenshot 2024-04-09 at 21 53 57"
src="https://github.com/go-gitea/gitea/assets/115237/5ccbb3d6-643a-4f60-ba79-3572b36d5182 ">
<hr>
<img width="711" alt="Screenshot 2024-04-09 at 21 44 24"
src="https://github.com/go-gitea/gitea/assets/115237/6ffe8fbb-407c-4aa7-b591-3d80daea7d57 ">
<hr>
<img width="439" alt="Screenshot 2024-04-09 at 21 19 03"
src="https://github.com/go-gitea/gitea/assets/115237/1ec7f6e9-2fd8-4841-87eb-6ca02ab9cd61 ">
<hr>
<img width="444" alt="Screenshot 2024-04-09 at 21 18 52"
src="https://github.com/go-gitea/gitea/assets/115237/70931b9e-5841-477e-b3bc-98f8d2662964 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-10 06:13:22 +00:00
226a82a939
Migrate font-family to tailwind ( #30118 )
...
Enable us to use tailwind's
[`font-family`](https://tailwindcss.com/docs/font-family ) classes as
well as remove `gt-mono` in favor of `tw-font-mono`. I also merged the
"compensation" to one selector, previously this was two different values
0.9em and 0.95em. I did not declare a `serif` font because I don't think
there will ever be a use case for those. Command ran:
```sh
perl -p -i -e 's#gt-mono#tw-font-mono#g' web_src/js/**/* templates/**/*
2024-03-28 08:31:07 +00:00
