19475 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
GiteaBot	3c95b0758f	[skip ci] Updated translations via Crowdin	2025-03-27 00:33:53 +00:00
Lunny Xiao	0c6957ef8d	Download actions job logs from API (#33858) ... Related to #33709, #31416 It's similar with https://docs.github.com/en/rest/actions/workflow-jobs?apiVersion=2022-11-28#download-job-logs-for-a-workflow-run--code-samples. This use `job_id` as path parameter which is consistent with Github's APIs. --------- Co-authored-by: ChristopherHX <christopher.homberger@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-26 11:30:52 -07:00
Royce Remer	e0ad72e223	Fail mirroring more gracefully (#34002) ... * reuse recoverable error checks across mirror_pull * add new cases for 'cannot lock ref/not our ref' (race condition in fetch) and 'Unable to create/lock" * move lfs sync right after commit graph write, and before other maintenance which may fail * try a prune for 'broken reference' as well as 'not our ref' * always sync LFS right after commit graph write, and before other maintenance which may fail This handles a few cases where our very large and very active repositories could serve mirrored git refs, but be missing lfs files: ## Case 1 (multiple variants): Race condition in git fetch There was already a check for 'unable to resolve reference' on a failed git fetch, after which a git prune and then subsequent fetch are performed. This is to work around a race condition where the git remote tells Gitea about a ref for some HEAD of a branch, then fails a few seconds later because the remote branch was deleted, or the ref was updated (force push). There are two more variants to the error message you can get, but for the same kind of race condition. These *may* be related to the git binary version Gitea has access to (in my case, it was 2.48.1). ## Case 2: githttp.go can serve updated git refs before it's synced lfs oids There is probably a more aggressive refactor we could do here to have the cat-file loop use FETCH_HEAD instead of relying on the commit graphs to be committed locally (and thus serveable to clients of Gitea), but a simple reduction in the occurrences of this for me was to move the lfs sync block immediately after the commit-graph write and before any other time-consuming (or potentially erroring/exiting) blocks. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-26 18:04:46 +00:00
wxiaoguang	c7b85f7070	Fix dropdown module accessing (#34026) ... Follow #34014.	2025-03-26 16:01:43 +00:00
wxiaoguang	d70be9d0fe	Polyfill WeakRef (#34025) ... Fix #33407	2025-03-26 23:56:25 +08:00
wxiaoguang	d28a7f9fea	Fix dropdown delegating and some UI problems (#34014) ... The old logic is incomplete. See the comment for the improved logic. Fix #34011 And more fixes: 1. use empty "alt" for images, otherwise the width is not right when the image fails to load 2. remove the "dropdown icon" patch, because it has been clearly done in "dropdown.js" now 3. remove the "dropdown filtered item" patch, added a clear callback, and improve the logic 4. fix global init when a node is removed and added back gain (eg: the "cherry pick" dialog with a dropdown)	2025-03-26 02:51:22 +00:00
silverwind	2089401653	Enable color output in govulncheck (#34012) ... Make `govulncheck` show color, which by default it doesn't for some reason.	2025-03-25 18:24:48 +00:00
Rafael de Mattos	20c7392e99	Update Makefile test comments (#34013) ... The comments are referring to the wrong project section (backend and frontend).	2025-03-25 17:54:17 +00:00
Lunny Xiao	d6e94fa4e4	Move duplicated functions (#33977) ... Remove duplicated functions `IsExist`, `IsFile` and `IsDir` in package `modules/git` and use the exists functions in `modules/util`.	2025-03-25 14:40:31 +00:00
Lunny Xiao	356b707dde	Git client will follow 301 but 307 (#34005) ... Fix #28460 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-25 07:20:08 +00:00
wxiaoguang	41c946a66f	Prepare common tmpl functions in a middleware (#33957) ... Fix the TODO in `routers/web/web.go`, and avoid the unnecessary `GetActiveStopwatch` SQL query in non-related route handlers.	2025-03-25 06:17:58 +00:00
wxiaoguang	32258e0f22	Update go mod dependencies (#33988) ... blevesearch is skipped because it causes errors --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2025-03-25 05:51:52 +00:00
wxiaoguang	51d86adb6d	Fix some migration and repo name problems (#33986) ... 1. Ignore empty inputs in `UnmarshalHandleDoubleEncode` 2. Ignore non-existing `stateEvent.User` in gitlab migration 3. Enable `release` and `wiki` units when they are selected in migration 4. Sanitize repo name for migration and new repo	2025-03-24 20:26:58 -07:00
GiteaBot	536f4c6de8	[skip ci] Updated translations via Crowdin	2025-03-25 00:34:21 +00:00
Lunny Xiao	3fe449c21a	Use filepath.Join instead of path.Join for file system file operations (#33978)	2025-03-24 14:50:28 -07:00
Lunny Xiao	82bc8b8ce6	Add changelog for 1.23.6 (#33975) ... Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: techknowlogick <techknowlogick@gitea.io>	2025-03-24 11:35:02 -07:00
wxiaoguang	8745129c9c	Fix incorrect code search indexer options (#33992) ... Fix #33798 Co-authored-by: Giteabot <teabot@gitea.io>	2025-03-24 17:18:21 +01:00
wxiaoguang	b1e326d09e	Auto expand "New PR" form (#33971) ... Follow GitHub's behavior: use `?expand=1` to expand the "New PR" form	2025-03-24 14:28:02 +00:00
Lunny Xiao	25b6f38865	Move ParseBool to optional (#33979)	2025-03-24 03:53:30 +00:00
GiteaBot	08510adefe	[skip ci] Updated translations via Crowdin	2025-03-24 00:35:25 +00:00
Lunny Xiao	30ee082e48	Only use prev and next buttons for pagination on user dashboard (#33981) ... The pagination on the user dashboard sounds unnecessary, this will change it to a prev/next buttons. For instances with around `10 million` records in the action table, this option affects how the user dashboard is loaded on first visit. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2025-03-23 19:52:43 +00:00
TheFox0x7	189873719b	update jwt and redis packages (#33984)	2025-03-23 10:13:16 -04:00
GiteaBot	0fee4f1392	[skip ci] Updated translations via Crowdin	2025-03-23 00:37:07 +00:00
wxiaoguang	e1bba9c1a2	Improve oauth2 error handling (#33969) ... Show the callback error to end users, it should be safe. Fix #33967	2025-03-22 10:15:45 +08:00
GiteaBot	1c5c13a442	[skip ci] Updated translations via Crowdin	2025-03-22 00:33:13 +00:00
silverwind	d1a755e5b7	Cover go.mod and go.sum in .editorconfig (#33960) ... These files were previously set to use spaces for indendation but they are supposed to use tabs, so set this in editorconfig.	2025-03-21 20:48:06 +00:00
Kai Leonhardt	b5d2e31d6d	Drop timeout for requests made to the internal hook api (#33947) ... This change targets https://github.com/go-gitea/gitea/issues/32663 We drop the hardcoded timeout of 60 seconds for requests to the internal hook api. With this change the timeout is completly removed. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-21 12:52:14 -07:00
charles	b956cee06f	Fix file name could not be searched if the file was not a text file when using the Bleve indexer (#33959) ... Close #33828 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-21 19:00:02 +00:00
wxiaoguang	279473f467	Fix oauth2 auth and UI (#33961)	2025-03-21 20:50:39 +08:00
Andreas Svanberg	0da7318cf3	Allow filtering issues by any assignee (#33343) ... This is the opposite of the "No assignee" filter, it will match all issues that have at least one assignee. Before  After  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-21 04:25:36 +00:00
Lunny Xiao	a4df01b580	Optimize total count of feed when loading activities in user dashboard. (#33841) ... Two SQLs are very slow when `action` table have over 5M records. ``` database duration=1.8881s db.sql="SELECT created_unix DIV 900 * 900 AS timestamp, count(user_id) as contributions FROM `action` WHERE user_id=? AND act_user_id=? AND (created_unix > ?) GROUP BY timestamp ORDER BY timestamp" database duration=1.5408s db.sql="SELECT count(*) FROM `action` WHERE (user_id = ?) AND (is_deleted = ?)" ``` This will cache the count for the first loading or when the activities changed.	2025-03-20 10:46:18 -07:00
Lunny Xiao	ef0970506f	Extract code to their own functions for push update (#33944)	2025-03-20 16:57:04 +00:00
Lunny Xiao	4a7ab0abf0	Optimize heatmap query (#33853) ... When there are over 5M records on `action` table, the heatmap on dashboard is very slow as below SQL. ``` database duration=1.8881s db.sql="SELECT created_unix DIV 900 * 900 AS timestamp, count(user_id) as contributions FROM `action` WHERE user_id=? AND act_user_id=? AND (created_unix > ?) GROUP BY timestamp ORDER BY timestamp" ``` This PR add a new index for `action` table with columns `user_id`, `act_user_id` and `created_unix` so that this query will become about 6 times faster than before.	2025-03-20 09:30:45 -07:00
TheFox0x7	5407382b43	Add cli flags LDAP group configuration (#33933) ... Add 7 new flags to ldap subcommands corresponding to UI options Closes CLI part of https://github.com/go-gitea/gitea/issues/20716	2025-03-19 17:29:37 -07:00
Lunny Xiao	a9e8ac0fe0	Don't create duplicated functions for code repositories and wiki repositories (#33924) ... Fix https://github.com/go-gitea/gitea/pull/33910#pullrequestreview-2688913865 This PR changed the Repositroy interface in `gitrepo` package which makes it only focus the relative path in the disk and abstract whether it's a wiki repository or not.	2025-03-19 11:17:19 -07:00
YaFou	e25f860735	Fix "toAbsoluteLocaleDate" test when system locale is not en-US (#33939)	2025-03-19 19:49:05 +08:00
GiteaBot	39fc2e7285	[skip ci] Updated translations via Crowdin	2025-03-19 00:33:36 +00:00
Kerwin Bryant	dcbf6c2d13	Optimize Layout Styles of Filelist (#33920) ... Align items --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-19 00:59:33 +08:00
GiteaBot	1b4adc0255	[skip ci] Updated translations via Crowdin	2025-03-18 00:33:31 +00:00
metiftikci	6e73ecf667	update go version for devcontainers (#33923)	2025-03-17 19:25:27 +00:00
John Smith	8f051d598c	Added Description Field for Secrets and Variables (#33526) ... Fixes #33484 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-17 19:24:54 +00:00
wxiaoguang	9d7c02f9f7	Try to figure out attribute checker problem (#33901) ... For #31600	2025-03-17 11:59:34 -07:00
wxiaoguang	fdaf1cca65	Defer captcha script loading (#33919) ... Fix #33899	2025-03-17 15:21:04 +00:00
Kerwin Bryant	e1feb438a4	Fix file tree issues (#33916)	2025-03-17 14:55:15 +00:00
wxiaoguang	9d89dfe142	Remove unused or abused styles (#33918) ... * `top aligned` => `tw-align-top` * label list: it was broken, this PR fixes it * reference link: simplified * settings/repos: not affected	2025-03-17 22:11:24 +08:00
GiteaBot	9ebae4a2aa	[skip ci] Updated translations via Crowdin	2025-03-17 00:35:08 +00:00
silverwind	18bd70054b	Update tool dependencies (#33907) ... `gopls` is currently excluded because its [new analyzers](https://github.com/golang/tools/releases/tag/gopls%2Fv0.18.0) raise many issue, to be fixed before we can upgrade it. And I think the modernize fixer still has a number of [unresolved/undiscovered bugs](https://github.com/golang/go/issues/71847).	2025-03-16 18:34:24 +00:00
Lunny Xiao	7fd44a85ca	Move hooks function to gitrepo and reduce expose repopath (#33890) ... Extract from #28966 Follow #33874	2025-03-16 16:12:55 +00:00
silverwind	1ea5216f4a	Replace text-align classes with tailwind (#33905) ... Small refactor to remove these CSS classes in favor of tailwind. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2025-03-16 12:08:16 +00:00
silverwind	01c8f092a0	Simplify secure context check (#33906) ... As discussed in https://github.com/go-gitea/gitea/pull/33820/files#r1997532169.	2025-03-16 19:05:26 +08:00