From a454ccd815c4fccc8dd6f8668f5704441b4fdc4b Mon Sep 17 00:00:00 2001
From: NightFyre <80198020+xCENTx@users.noreply.github.com>
Date: Fri, 26 Jan 2024 12:19:18 -0500
Subject: [PATCH] address compile errors

- 'SetCraftingSpeed': redefinition of default argument: parameter 1 NetCrack-PalWorld D:\case\repos\feature.cpp 78
- 'GetCharacterImpManager': function must return a value NetCrack-PalWorld D:\case\repos\config.cpp 53
- unresolved external symbol "Config::gWorld"
---
 config.cpp   | 16 ++++++++--------
 config.h     |  2 +-
 feature.cpp  |  2 +-
 src/Menu.cpp |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/config.cpp b/config.cpp
index 958ae91..c70b6f8 100644
--- a/config.cpp
+++ b/config.cpp
@@ -41,16 +41,16 @@ SDK::UWorld* config::GetUWorld()
         auto gworld = signature("48 8B 05 ? ? ? ? EB 05").instruction(3).add(7);
         gworld_ptr = gworld.GetPointer();
         if (gworld_ptr)
-            gWorld = *(SDK::UWorld**)gworld_ptr;
+            Config.gWorld = *(SDK::UWorld**)gworld_ptr;
     }
     return (*(SDK::UWorld**)(gworld_ptr));
 }
 
-SDK::UPalCharacterImportanceManager* GetCharacterImpManager()
+SDK::UPalCharacterImportanceManager* config::GetCharacterImpManager()
 {
-    SDK::UWorld* pWorld = config::gWorld;
+    SDK::UWorld* pWorld = Config.gWorld;
     if (!pWorld)
-        return;
+        return nullptr;
 
     SDK::UGameInstance* pGameInstance = pWorld->OwningGameInstance; 
     if (!pGameInstance) 
@@ -80,7 +80,7 @@ SDK::APalPlayerState* config::GetPalPlayerState()
 
 bool GetTAllPlayers(SDK::TArray<class SDK::APalCharacter*>* outResult)
 {
-    SDK::UPalCharacterImportanceManager* mPal = GetCharacterImpManager();
+    SDK::UPalCharacterImportanceManager* mPal = config::GetCharacterImpManager();
     if (!mPal)
         return false;
 
@@ -90,7 +90,7 @@ bool GetTAllPlayers(SDK::TArray<class SDK::APalCharacter*>* outResult)
 
 bool GetTAllImpNPC(SDK::TArray<class SDK::APalCharacter*>* outResult)
 {
-    SDK::UPalCharacterImportanceManager* mPal = GetCharacterImpManager();
+    SDK::UPalCharacterImportanceManager* mPal = config::GetCharacterImpManager();
     if (!mPal)
         return false;
 
@@ -100,7 +100,7 @@ bool GetTAllImpNPC(SDK::TArray<class SDK::APalCharacter*>* outResult)
 
 bool GetTAllNPC(SDK::TArray<class SDK::APalCharacter*>* outResult)
 {
-    SDK::UPalCharacterImportanceManager* mPal = GetCharacterImpManager();
+    SDK::UPalCharacterImportanceManager* mPal = config::GetCharacterImpManager();
     if (!mPal)
         return false;
 
@@ -110,7 +110,7 @@ bool GetTAllNPC(SDK::TArray<class SDK::APalCharacter*>* outResult)
 
 bool GetTAllPals(SDK::TArray<class SDK::APalCharacter*>* outResult)
 {
-    SDK::UPalCharacterImportanceManager* mPal = GetCharacterImpManager();
+    SDK::UPalCharacterImportanceManager* mPal = config::GetCharacterImpManager();
     if (!mPal)
         return false;
 
diff --git a/config.h b/config.h
index 5d14a19..e75e03d 100644
--- a/config.h
+++ b/config.h
@@ -39,7 +39,7 @@ public:
 	char ItemName[255];
 	char inputTextBuffer[255] = "";
 	int EqModifiler = 1;
-	static SDK::UWorld* gWorld;
+	SDK::UWorld* gWorld = nullptr;
 	SDK::APalPlayerCharacter* localPlayer = NULL;
 	SDK::TArray<SDK::APalPlayerCharacter*> AllPlayers = {};
 	SDK::UPalCharacterImportanceManager* UCIM = NULL;
diff --git a/feature.cpp b/feature.cpp
index c0e1a90..6e3f5fb 100644
--- a/feature.cpp
+++ b/feature.cpp
@@ -75,7 +75,7 @@ void SetInfiniteAmmo(bool bInfAmmo)
 
 }
 
-void SetCraftingSpeed(float mNewSpeed, bool bRestoreDefault = false)
+void SetCraftingSpeed(float mNewSpeed, bool bRestoreDefault)
 {
 	APalPlayerCharacter* pPalCharacter = Config.GetPalPlayerCharacter();
 	if (!pPalCharacter)
diff --git a/src/Menu.cpp b/src/Menu.cpp
index 251b981..7a37ca1 100644
--- a/src/Menu.cpp
+++ b/src/Menu.cpp
@@ -279,7 +279,7 @@ namespace DX11_Base {
                                 SDK::UPalItemContainerMultiHelper* InventoryMultiHelper = InventoryData->InventoryMultiHelper;
                                 if (InventoryMultiHelper != NULL) {
                                     SDK::TArray<class SDK::UPalItemContainer*> Containers = InventoryMultiHelper->Containers;
-                                    if (Containers.Num() == 0) {
+                                    if (Containers.Count() == 0) {
                                         return;
                                     }