sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-03 01:09:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Streamline panel selection event logic.

Browse Source 
Was previously firing multiple times where it was completely unnecessary. Also had bidirection firing going on.
This commit is contained in:
Dean Herbert
2017-04-28 20:43:42 +09:00
parent b78fa99620
commit 003cf53441
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Screens/Select/BeatmapCarousel.cs
View File

@ -120,7 +120,7 @@ namespace osu.Game.Screens.Select
public void RemoveBeatmap(BeatmapSetInfo info) => removeGroup(groups.Find(b => b.BeatmapSet.ID == info.ID));
public Action<BeatmapGroup, BeatmapInfo> SelectionChanged;
public Action<BeatmapInfo> SelectionChanged;
public Action StartRequested;
@ -230,7 +230,7 @@ namespace osu.Game.Screens.Select
return new BeatmapGroup(beatmapSet, database)
{
SelectionChanged = SelectionChanged,
SelectionChanged = (g, p) => selectGroup(g, p),
StartRequested = b => StartRequested?.Invoke(),
State = BeatmapGroupState.Collapsed
};
@ -345,6 +345,8 @@ namespace osu.Game.Screens.Select
float selectedY = computeYPositions(animated);
ScrollTo(selectedY, animated);
SelectionChanged?.Invoke(panel.Beatmap);
}
protected override bool OnKeyDown(InputState state, KeyDownEventArgs args)