sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-04 23:24:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Maintain a placeholder state and add tests showing all the states.

Browse Source 
- Also don't replace placeholder if new one is same as old
This commit is contained in:
naoey
2017-12-21 15:17:37 +05:30
parent afcb9912e4
commit 01c4b1e544
2 changed files with 127 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
osu.Game.Tests/Visual/TestCaseLeaderboard.cs
View File

@ -9,7 +9,6 @@ using osu.Game.Users;
using osu.Framework.Allocation;
using OpenTK;
using System.Linq;
using System.Net;
using osu.Game.Beatmaps;
using osu.Game.Rulesets;
@ -33,8 +32,10 @@ namespace osu.Game.Tests.Visual
});
AddStep(@"New Scores", newScores);
AddStep(@"Empty Scores", () => leaderboard.Scores = Enumerable.Empty<Score>());
AddStep(@"Network failure", networkFailure);
AddStep(@"Empty Scores", () => leaderboard.SetRetrievalState(PlaceholderState.NoScores));
AddStep(@"Network failure", () => leaderboard.SetRetrievalState(PlaceholderState.NetworkFailure));
AddStep(@"No supporter", () => leaderboard.SetRetrievalState(PlaceholderState.NotSupporter));
AddStep(@"Not logged in", () => leaderboard.SetRetrievalState(PlaceholderState.NotLoggedIn));
AddStep(@"Real beatmap", realBeatmap);
}
@ -265,19 +266,11 @@ namespace osu.Game.Tests.Visual
};
}
private void networkFailure()
{
leaderboard.Beatmap = new BeatmapInfo { Ruleset = rulesets.GetRuleset(0) };
}
private class FailableLeaderboard : Leaderboard
{
protected override void UpdateScores()
public void SetRetrievalState(PlaceholderState state)
{
if (Beatmap?.OnlineBeatmapID == null)
OnUpdateFailed(new WebException());
else
base.UpdateScores();
PlaceholderState = state;
}
}
}