sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-25 23:47:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

Disallow setting "NoScores" externally as it is handled internally

Browse Source
This commit is contained in:
Dean Herbert 2022-01-30 16:16:33 +09:00
parent acc1199add
commit 04dbb5d3c6
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapLeaderboard.cs
View File

@ -114,7 +114,8 @@ namespace osu.Game.Tests.Visual.SongSelect
[Test] [Test]
public void TestPlaceholderStates() public void TestPlaceholderStates()
{ {
AddStep(@"Empty Scores", () => leaderboard.SetErrorState(LeaderboardErrorState.NoScores)); AddStep("ensure no scores displayed", () => leaderboard.SetScores(null));
AddStep(@"Network failure", () => leaderboard.SetErrorState(LeaderboardErrorState.NetworkFailure)); AddStep(@"Network failure", () => leaderboard.SetErrorState(LeaderboardErrorState.NetworkFailure));
AddStep(@"No supporter", () => leaderboard.SetErrorState(LeaderboardErrorState.NotSupporter)); AddStep(@"No supporter", () => leaderboard.SetErrorState(LeaderboardErrorState.NotSupporter));
AddStep(@"Not logged in", () => leaderboard.SetErrorState(LeaderboardErrorState.NotLoggedIn)); AddStep(@"Not logged in", () => leaderboard.SetErrorState(LeaderboardErrorState.NotLoggedIn));

3
osu.Game/Online/Leaderboards/Leaderboard.cs
View File

@ -165,6 +165,7 @@ namespace osu.Game.Online.Leaderboards
{ {
switch (errorState) switch (errorState)
{ {
case LeaderboardErrorState.NoScores:
case LeaderboardErrorState.NoError: case LeaderboardErrorState.NoError:
throw new InvalidOperationException($"State {errorState} cannot be set by a leaderboard implementation."); throw new InvalidOperationException($"State {errorState} cannot be set by a leaderboard implementation.");
} }
@ -250,7 +251,7 @@ namespace osu.Game.Online.Leaderboards
if (scores?.Any() != true) if (scores?.Any() != true)
{ {
SetErrorState(LeaderboardErrorState.NoScores); setErrorState(LeaderboardErrorState.NoScores);
loading.Hide(); loading.Hide();
return; return;
} }