sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-07 22:57:31 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #10935 from bdach/fix-mania-judgement-fade-in

Browse Source 
Rewind judgement transforms before clearing
This commit is contained in:
Dean Herbert 2020-11-23 17:05:04 +09:00 committed by GitHub
commit 060acb9010
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Rulesets/Judgements/DrawableJudgement.cs
View File

@ -149,7 +149,10 @@ namespace osu.Game.Rulesets.Judgements
private void runAnimation() private void runAnimation()
{ {
// undo any transforms applies in ApplyMissAnimations/ApplyHitAnimations to get a sane initial state.
ApplyTransformsAt(double.MinValue, true);
ClearTransforms(true); ClearTransforms(true);
LifetimeStart = Result.TimeAbsolute; LifetimeStart = Result.TimeAbsolute;
using (BeginAbsoluteSequence(Result.TimeAbsolute, true)) using (BeginAbsoluteSequence(Result.TimeAbsolute, true))

2
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -439,6 +439,8 @@ namespace osu.Game.Rulesets.Objects.Drawables
private void clearExistingStateTransforms() private void clearExistingStateTransforms()
{ {
base.ApplyTransformsAt(double.MinValue, true); base.ApplyTransformsAt(double.MinValue, true);
// has to call this method directly (not ClearTransforms) to bypass the local ClearTransformsAfter override.
base.ClearTransformsAfter(double.MinValue, true); base.ClearTransformsAfter(double.MinValue, true);
} }