sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 08:03:52 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rename Stop{SampleAndRemoveFilters -> }()

Browse Source 
Now that just one method for stopping samples is left, let's just
repurpose st as the general "stop global effects" method rather than
have it there with a hyperspecific name. It also has good symmetry, as
there already was a `Start()` method in the class.
This commit is contained in:
Bartłomiej Dach
2023-01-22 09:27:06 +01:00
parent 9e4e85e3e3
commit 06aa3f7798
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Screens/Play/FailAnimation.cs
View File

@ -154,7 +154,10 @@ namespace osu.Game.Screens.Play
Background?.FadeColour(OsuColour.Gray(0.3f), 60); Background?.FadeColour(OsuColour.Gray(0.3f), 60);
} }
public void StopSampleAndRemoveFilters() /// <summary>
/// Stops any and all persistent effects added by the ongoing fail animation.
/// </summary>
public void Stop()
{ {
failSampleChannel?.Stop(); failSampleChannel?.Stop();
removeFilters(); removeFilters();

2
osu.Game/Screens/Play/Player.cs
View File

@ -1072,7 +1072,7 @@ namespace osu.Game.Screens.Play
public override bool OnExiting(ScreenExitEvent e) public override bool OnExiting(ScreenExitEvent e)
{ {
screenSuspension?.RemoveAndDisposeImmediately(); screenSuspension?.RemoveAndDisposeImmediately();
failAnimationLayer?.StopSampleAndRemoveFilters(); failAnimationLayer?.Stop();
if (LoadedBeatmapSuccessfully) if (LoadedBeatmapSuccessfully)
{ {