sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-01 16:29:58 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix race due to StopWatchingUser() being called asynchronously

Browse Source
This commit is contained in:
smoogipoo
2021-05-20 19:45:11 +09:00
parent 5a8b8782d3
commit 06c99e8c7c
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Online/Spectator/SpectatorClient.cs
View File

@ -182,9 +182,13 @@ namespace osu.Game.Online.Spectator
public void StopWatchingUser(int userId) public void StopWatchingUser(int userId)
{ {
watchingUsers.Remove(userId); // This method is most commonly called via Dispose(), which is asynchronous.
// Todo: This should not be a thing, but requires framework changes.
StopWatchingUserInternal(userId); Schedule(() =>
{
watchingUsers.Remove(userId);
StopWatchingUserInternal(userId);
});
} }
protected abstract Task BeginPlayingInternal(SpectatorState state); protected abstract Task BeginPlayingInternal(SpectatorState state);