From 0bd7486a832e0ec701e54d8ed5b271e1190d4a1c Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 20 Jan 2022 17:29:03 +0900
Subject: [PATCH] Avoid constructor overhead for realm `SkinInfo` parameterless
 constructor

---
 osu.Game/Skinning/SkinInfo.cs | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/osu.Game/Skinning/SkinInfo.cs b/osu.Game/Skinning/SkinInfo.cs
index fee8c3edb2..a89725e466 100644
--- a/osu.Game/Skinning/SkinInfo.cs
+++ b/osu.Game/Skinning/SkinInfo.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using JetBrains.Annotations;
 using Newtonsoft.Json;
 using osu.Framework.Extensions.ObjectExtensions;
 using osu.Framework.Testing;
@@ -26,16 +27,16 @@ namespace osu.Game.Skinning
 
         [PrimaryKey]
         [JsonProperty]
-        public Guid ID { get; set; } = Guid.NewGuid();
+        public Guid ID { get; set; }
 
         [JsonProperty]
-        public string Name { get; set; } = string.Empty;
+        public string Name { get; set; } = null!;
 
         [JsonProperty]
-        public string Creator { get; set; } = string.Empty;
+        public string Creator { get; set; } = null!;
 
         [JsonProperty]
-        public string InstantiationInfo { get; set; } = string.Empty;
+        public string InstantiationInfo { get; set; } = null!;
 
         public string Hash { get; set; } = string.Empty;
 
@@ -55,6 +56,19 @@ namespace osu.Game.Skinning
 
         public bool DeletePending { get; set; }
 
+        public SkinInfo(string? name = null, string? creator = null, string? instantiationInfo = null)
+        {
+            Name = name ?? string.Empty;
+            Creator = creator ?? string.Empty;
+            InstantiationInfo = instantiationInfo ?? string.Empty;
+            ID = Guid.NewGuid();
+        }
+
+        [UsedImplicitly] // Realm
+        private SkinInfo()
+        {
+        }
+
         public bool Equals(SkinInfo? other)
         {
             if (ReferenceEquals(this, other)) return true;