sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 09:03:50 +09:00
Code Issues Packages Projects Releases Wiki Activity

Better handle Statistics to avoid losing data

Browse Source
This commit is contained in:
Dean Herbert
2022-01-08 00:39:39 +09:00
parent 76670a8faa
commit 13401a8846
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Scoring/ScoreInfo.cs
View File

@ -83,21 +83,22 @@ namespace osu.Game.Scoring
public RulesetInfo Ruleset { get; set; } = null!; public RulesetInfo Ruleset { get; set; } = null!;
private Dictionary<HitResult, int>? statistics;
[Ignored] [Ignored]
public Dictionary<HitResult, int> Statistics public Dictionary<HitResult, int> Statistics
{ {
// TODO: this is dangerous. a get operation may then modify the dictionary, which would be a fresh copy that is not persisted with the model.
// this is already the case in multiple locations.
get get
{ {
if (string.IsNullOrEmpty(StatisticsJson)) if (statistics != null)
return new Dictionary<HitResult, int>(); return statistics;
return JsonConvert.DeserializeObject<Dictionary<HitResult, int>>(StatisticsJson) ?? new Dictionary<HitResult, int>(); if (!string.IsNullOrEmpty(StatisticsJson))
statistics = JsonConvert.DeserializeObject<Dictionary<HitResult, int>>(StatisticsJson);
return statistics ??= new Dictionary<HitResult, int>();
} }
// .. todo set => statistics = value;
// ReSharper disable once ValueParameterNotUsed
set => JsonConvert.SerializeObject(StatisticsJson);
} }
[MapTo("Statistics")] [MapTo("Statistics")]