sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 23:53:51 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add comment explaining texelSize value

Browse Source
This commit is contained in:
Andrei Zavatski
2023-02-03 10:32:41 +03:00
parent 175b9fc5c9
commit 14524237ac
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Graphics/Backgrounds/Triangles.cs
View File

@ -253,7 +253,6 @@ namespace osu.Game.Graphics.Backgrounds
private class TrianglesDrawNode : DrawNode private class TrianglesDrawNode : DrawNode
{ {
private float fill = 1f; private float fill = 1f;
private float texelSize = 0f;
protected new Triangles Source => (Triangles)base.Source; protected new Triangles Source => (Triangles)base.Source;
@ -295,6 +294,11 @@ namespace osu.Game.Graphics.Backgrounds
vertexBatch = renderer.CreateQuadBatch<TexturedVertex2D>(Source.AimCount, 1); vertexBatch = renderer.CreateQuadBatch<TexturedVertex2D>(Source.AimCount, 1);
} }
//Due to triangles having various sizes we would need to set a different "texelSize" value for each of them, which is insanely expensive, thus we should use one single value.
//texelSize computed for an average triangle (size 100) will result in big triangles becoming blurry, so we may just use 0 for all of them.
//But we still need to specify at least something, because otherwise other shader usages will override this value.
float texelSize = 0f;
shader.Bind(); shader.Bind();
shader.GetUniform<float>("thickness").UpdateValue(ref fill); shader.GetUniform<float>("thickness").UpdateValue(ref fill);
shader.GetUniform<float>("texelSize").UpdateValue(ref texelSize); shader.GetUniform<float>("texelSize").UpdateValue(ref texelSize);