sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 16:59:53 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix failing test scenes

Browse Source
This commit is contained in:
Salman Ahmed
2022-03-20 16:17:19 +03:00
parent 5f878ed82b
commit 145fca2704
2 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Tests/Mods/ModUtilsTest.cs
View File

@ -134,18 +134,6 @@ namespace osu.Game.Tests.Mods
private static readonly object[] invalid_mod_test_scenarios = private static readonly object[] invalid_mod_test_scenarios =
{ {
// incompatible pair.
new object[]
{
new Mod[] { new OsuModDoubleTime(), new OsuModHalfTime() },
new[] { typeof(OsuModDoubleTime), typeof(OsuModHalfTime) }
},
// incompatible pair with derived class.
new object[]
{
new Mod[] { new OsuModNightcore(), new OsuModHalfTime() },
new[] { typeof(OsuModNightcore), typeof(OsuModHalfTime) }
},
// system mod. // system mod.
new object[] new object[]
{ {

6
osu.Game/Utils/ModUtils.cs
View File

@ -106,7 +106,7 @@ namespace osu.Game.Utils
} }
/// <summary> /// <summary>
/// Check the provided combination of mods are valid for a local gameplay session. /// Checks that all <see cref="Mod"/>s in a combination are valid for a local gameplay session.
/// </summary> /// </summary>
/// <param name="mods">The mods to check.</param> /// <param name="mods">The mods to check.</param>
/// <param name="invalidMods">Invalid mods, if any were found. Will be null if all mods were valid.</param> /// <param name="invalidMods">Invalid mods, if any were found. Will be null if all mods were valid.</param>
@ -115,7 +115,7 @@ namespace osu.Game.Utils
=> checkValid(mods, m => m.Type != ModType.System && m.HasImplementation && !(m is MultiMod), out invalidMods); => checkValid(mods, m => m.Type != ModType.System && m.HasImplementation && !(m is MultiMod), out invalidMods);
/// <summary> /// <summary>
/// Check the provided combination of mods are valid as "required mods" in a multiplayer match session. /// Checks that all <see cref="Mod"/>s in a combination are valid as "required mods" in a multiplayer match session.
/// </summary> /// </summary>
/// <param name="mods">The mods to check.</param> /// <param name="mods">The mods to check.</param>
/// <param name="invalidMods">Invalid mods, if any were found. Will be null if all mods were valid.</param> /// <param name="invalidMods">Invalid mods, if any were found. Will be null if all mods were valid.</param>
@ -124,7 +124,7 @@ namespace osu.Game.Utils
=> checkValid(mods, m => m.IsPlayable(ModUsage.MultiplayerRoomWide), out invalidMods); => checkValid(mods, m => m.IsPlayable(ModUsage.MultiplayerRoomWide), out invalidMods);
/// <summary> /// <summary>
/// Check the provided combination of mods are valid as "free mods" in a multiplayer match session. /// Checks that all <see cref="Mod"/>s in a combination are valid as "free mods" in a multiplayer match session.
/// </summary> /// </summary>
/// <param name="mods">The mods to check.</param> /// <param name="mods">The mods to check.</param>
/// <param name="invalidMods">Invalid mods, if any were found. Will be null if all mods were valid.</param> /// <param name="invalidMods">Invalid mods, if any were found. Will be null if all mods were valid.</param>