sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 00:53:56 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add more test checks and fix deserialisation test

Browse Source
This commit is contained in:
mk56-spn
2022-12-11 23:58:10 +01:00
parent 4c17b27273
commit 161894da3b
4 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

BIN
osu.Game.Tests/Resources/Archives/modified-default-20221211.osk Normal file
View File

Binary file not shown.

4
osu.Game.Tests/Skins/SkinDeserialisationTest.cs
View File

@ -42,7 +42,9 @@ namespace osu.Game.Tests.Skins
// Covers longest combo counter // Covers longest combo counter
"Archives/modified-default-20221012.osk", "Archives/modified-default-20221012.osk",
// Covers TextElement and BeatmapInfoDrawable // Covers TextElement and BeatmapInfoDrawable
"Archives/modified-default-20221102.osk" "Archives/modified-default-20221102.osk",
// Covers JudgementCounter
"Archives/modified-default-20221211.osk"
}; };
/// <summary> /// <summary>

5
osu.Game.Tests/Visual/Gameplay/TestSceneJudgementCounter.cs
View File

@ -102,9 +102,12 @@ namespace osu.Game.Tests.Visual.Gameplay
} }
[Test] [Test]
public void TestHideJudgementNames() public void TestToggleJudgementNames()
{ {
AddStep("Hide judgement names", () => counter.ShowName.Value = false); AddStep("Hide judgement names", () => counter.ShowName.Value = false);
AddAssert("Assert hidden", () => counter.JudgementContainer.Children.OfType<JudgementCounter>().First().ResultName.Alpha == 0);
AddStep("Hide judgement names", () => counter.ShowName.Value = true);
AddAssert("Assert shown", () => counter.JudgementContainer.Children.OfType<JudgementCounter>().First().ResultName.Alpha == 1);
} }
[Test] [Test]

10
osu.Game/Screens/Play/HUD/JudgementCounter/JudgementCounter.cs
View File

@ -24,7 +24,7 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
Result = result; Result = result;
} }
private OsuSpriteText resultName = null!; public OsuSpriteText ResultName = null!;
private FillFlowContainer flowContainer = null!; private FillFlowContainer flowContainer = null!;
private JudgementRollingCounter counter = null!; private JudgementRollingCounter counter = null!;
@ -41,7 +41,7 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
{ {
Current = Result.ResultCount Current = Result.ResultCount
}, },
resultName = new OsuSpriteText ResultName = new OsuSpriteText
{ {
Font = OsuFont.Numeric.With(size: 8), Font = OsuFont.Numeric.With(size: 8),
Text = Result.ResultInfo.Displayname Text = Result.ResultInfo.Displayname
@ -72,11 +72,11 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
{ {
if (value.NewValue) if (value.NewValue)
{ {
resultName.Show(); ResultName.Show();
return; return;
} }
resultName.Hide(); ResultName.Hide();
}, true); }, true);
Direction.BindValueChanged(direction => Direction.BindValueChanged(direction =>
@ -91,7 +91,7 @@ namespace osu.Game.Screens.Play.HUD.JudgementCounter
changeAnchor(Anchor.BottomLeft); changeAnchor(Anchor.BottomLeft);
void changeAnchor(Anchor anchor) => counter.Anchor = resultName.Anchor = counter.Origin = resultName.Origin = anchor; void changeAnchor(Anchor anchor) => counter.Anchor = ResultName.Anchor = counter.Origin = ResultName.Origin = anchor;
}, true); }, true);
base.LoadComplete(); base.LoadComplete();