sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-29 17:37:23 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rework ChannelTabControl's AddChannel method to not auto select and let ChatOverlay handle this

Browse Source
This commit is contained in:
Craftplacer 2020-01-19 18:20:42 +01:00
parent 5f96940b7d
commit 1681e16738
2 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Overlays/Chat/Tabs/ChannelTabControl.cs
View File

@ -59,17 +59,12 @@ namespace osu.Game.Overlays.Chat.Tabs
/// <summary> /// <summary>
/// Adds a channel to the ChannelTabControl. /// Adds a channel to the ChannelTabControl.
/// The first channel added will automaticly selected if <paramref name="setChannel"/> is true.
/// </summary> /// </summary>
/// <param name="channel">The channel that is going to be added.</param> /// <param name="channel">The channel that is going to be added.</param>
/// <param name="setChannel">If the current channel should be changed if none was selected before</param> public void AddChannel(Channel channel)
public void AddChannel(Channel channel, bool setChannel = true)
{ {
if (!Items.Contains(channel)) if (!Items.Contains(channel))
AddItem(channel); AddItem(channel);
if (Current.Value == null && setChannel)
Current.Value = channel;
} }
/// <summary> /// <summary>

7
osu.Game/Overlays/ChatOverlay.cs
View File

@ -222,13 +222,10 @@ namespace osu.Game.Overlays
channelManager.JoinedChannels.ItemsAdded += onChannelAddedToJoinedChannels; channelManager.JoinedChannels.ItemsAdded += onChannelAddedToJoinedChannels;
channelManager.JoinedChannels.ItemsRemoved += onChannelRemovedFromJoinedChannels; channelManager.JoinedChannels.ItemsRemoved += onChannelRemovedFromJoinedChannels;
bool channelSelected = channelManager.CurrentChannel.Value != null;
foreach (Channel channel in channelManager.JoinedChannels) foreach (Channel channel in channelManager.JoinedChannels)
ChannelTabControl.AddChannel(channel, !channelSelected); ChannelTabControl.AddChannel(channel);
if (channelSelected) ChannelTabControl.Current.Value = channelManager.CurrentChannel.Value ?? channelManager.JoinedChannels.First();
ChannelTabControl.Current.Value = channelManager.CurrentChannel.Value;
channelManager.AvailableChannels.ItemsAdded += availableChannelsChanged; channelManager.AvailableChannels.ItemsAdded += availableChannelsChanged;
channelManager.AvailableChannels.ItemsRemoved += availableChannelsChanged; channelManager.AvailableChannels.ItemsRemoved += availableChannelsChanged;