Merge https://github.com/ppy/osu into beatmap-set-status

osu.Game/Online/API/APIAccess.cs

@@ -64,7 +64,7 @@ namespace osu.Game.Online.API
 
         private readonly List<IOnlineComponent> components = new List<IOnlineComponent>();
 
-        internal void Schedule(Action action) => base.Schedule(action);
+        internal new void Schedule(Action action) => base.Schedule(action);
 
         public void Register(IOnlineComponent component)
         {

osu.Game/Online/API/OAuth.cs

@@ -96,6 +96,7 @@ namespace osu.Game.Online.API
 
                 // if not, let's try using our refresh token to request a new access token.
                 if (!string.IsNullOrEmpty(Token?.RefreshToken))
+                    // ReSharper disable once PossibleNullReferenceException
                     AuthenticateWithRefresh(Token.RefreshToken);
 
                 return accessTokenValid;

osu.Game/Online/API/Requests/GetUserBeatmapsRequest.cs

@@ -19,6 +19,7 @@ namespace osu.Game.Online.API.Requests
             this.type = type;
         }
 
+        // ReSharper disable once ImpureMethodCallOnReadonlyValueField
         protected override string Target => $@"users/{userId}/beatmapsets/{type.ToString().Underscore()}?offset={offset}";
     }
 

osu.Game/Online/API/Requests/GetUserScoresRequest.cs

@@ -18,6 +18,7 @@ namespace osu.Game.Online.API.Requests
             this.offset = offset;
         }
 
+        // ReSharper disable once ImpureMethodCallOnReadonlyValueField
         protected override string Target => $@"users/{userId}/scores/{type.ToString().ToLower()}?offset={offset}";
     }
 

osu.Game/Online/API/Requests/SearchBeatmapSetsRequest.cs

@@ -27,6 +27,7 @@ namespace osu.Game.Online.API.Requests
             this.direction = direction;
         }
 
+        // ReSharper disable once ImpureMethodCallOnReadonlyValueField
         protected override string Target => $@"beatmapsets/search?q={query}&m={ruleset.ID ?? 0}&s={(int)rankStatus}&sort={sortCriteria.ToString().ToLower()}_{directionString}";
     }
 }