sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 00:40:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Update mod instantiaton utility method to no longer check for validity

Browse Source
This commit is contained in:
Salman Ahmed
2022-03-17 05:51:12 +03:00
parent 52d1c0cc15
commit 1a04260807
1 changed files with 6 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
osu.Game/Utils/ModUtils.cs
View File

@ -153,31 +153,17 @@ namespace osu.Game.Utils
} }
/// <summary> /// <summary>
/// Verifies all proposed mods are valid for a given ruleset and returns instantiated <see cref="Mod"/>s for further processing. /// Returns an instantiated list of all proposed mods on a given ruleset.
/// </summary> /// </summary>
/// <param name="ruleset">The ruleset to verify mods against.</param> /// <param name="ruleset">The ruleset to instantiate mods.</param>
/// <param name="proposedMods">The proposed mods.</param> /// <param name="proposedMods">The proposed mods.</param>
/// <param name="valid">Mods instantiated from <paramref name="proposedMods"/> which were valid for the given <paramref name="ruleset"/>.</param> /// <param name="mods">Mods instantiated from <paramref name="proposedMods"/> on the given <paramref name="ruleset"/>.</param>
/// <returns>Whether all <paramref name="proposedMods"/> were valid for the given <paramref name="ruleset"/>.</returns> public static void InstantiateModsForRuleset(Ruleset ruleset, IEnumerable<APIMod> proposedMods, out List<Mod> mods)
public static bool InstantiateValidModsForRuleset(Ruleset ruleset, IEnumerable<APIMod> proposedMods, out List<Mod> valid)
{ {
valid = new List<Mod>(); mods = new List<Mod>();
bool proposedWereValid = true;
foreach (var apiMod in proposedMods) foreach (var apiMod in proposedMods)
{ mods.Add(apiMod.ToMod(ruleset));
try
{
// will throw if invalid
valid.Add(apiMod.ToMod(ruleset));
}
catch
{
proposedWereValid = false;
}
}
return proposedWereValid;
} }
} }
} }