From 1a318c5c2b87f4fa4161552ac717c5846fe54999 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 22 Dec 2017 18:58:35 +0900
Subject: [PATCH] Improve LineGraph invalidation logic

---
 osu.Game.Tests/Visual/TestCaseUserProfile.cs | 11 ++++++
 osu.Game/Graphics/UserInterface/LineGraph.cs | 38 ++++++++++++++------
 2 files changed, 39 insertions(+), 10 deletions(-)

diff --git a/osu.Game.Tests/Visual/TestCaseUserProfile.cs b/osu.Game.Tests/Visual/TestCaseUserProfile.cs
index 697b84941c..7f2e7779d9 100644
--- a/osu.Game.Tests/Visual/TestCaseUserProfile.cs
+++ b/osu.Game.Tests/Visual/TestCaseUserProfile.cs
@@ -2,14 +2,25 @@
 // Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE
 
 using System;
+using System.Collections.Generic;
 using System.Linq;
+using osu.Game.Graphics.UserInterface;
 using osu.Game.Overlays;
+using osu.Game.Overlays.Profile;
 using osu.Game.Users;
 
 namespace osu.Game.Tests.Visual
 {
     public class TestCaseUserProfile : OsuTestCase
     {
+        public override IReadOnlyList<Type> RequiredTypes => new[]
+        {
+            typeof(ProfileHeader),
+            typeof(UserProfileOverlay),
+            typeof(RankChart),
+            typeof(LineGraph),
+        };
+
         public TestCaseUserProfile()
         {
             var profile = new UserProfileOverlay();
diff --git a/osu.Game/Graphics/UserInterface/LineGraph.cs b/osu.Game/Graphics/UserInterface/LineGraph.cs
index aa9256e576..ea74c67f6c 100644
--- a/osu.Game/Graphics/UserInterface/LineGraph.cs
+++ b/osu.Game/Graphics/UserInterface/LineGraph.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using osu.Framework.Caching;
 using OpenTK;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
@@ -47,7 +48,16 @@ namespace osu.Game.Graphics.UserInterface
             set
             {
                 values = value.ToArray();
-                applyPath();
+
+                float max = values.Max(), min = values.Min();
+                if (MaxValue > max) max = MaxValue.Value;
+                if (MinValue < min) min = MinValue.Value;
+
+                ActualMaxValue = max;
+                ActualMinValue = min;
+
+                pathCached.Invalidate();
+
                 maskingContainer.Width = 0;
                 maskingContainer.ResizeWidthTo(1, transform_duration, Easing.OutQuint);
             }
@@ -63,13 +73,28 @@ namespace osu.Game.Graphics.UserInterface
             });
         }
 
+        private bool pending;
+
         public override bool Invalidate(Invalidation invalidation = Invalidation.All, Drawable source = null, bool shallPropagate = true)
         {
-            if ((invalidation & Invalidation.DrawSize) != 0)
-                applyPath();
+            if ((invalidation & Invalidation.DrawSize) > 0)
+                pathCached.Invalidate();
+
             return base.Invalidate(invalidation, source, shallPropagate);
         }
 
+        private Cached pathCached = new Cached();
+
+        protected override void Update()
+        {
+            base.Update();
+            if (!pathCached.IsValid)
+            {
+                applyPath();
+                pathCached.Validate();
+            }
+        }
+
         private void applyPath()
         {
             path.ClearVertices();
@@ -77,13 +102,6 @@ namespace osu.Game.Graphics.UserInterface
 
             int count = Math.Max(values.Length, DefaultValueCount);
 
-            float max = values.Max(), min = values.Min();
-            if (MaxValue > max) max = MaxValue.Value;
-            if (MinValue < min) min = MinValue.Value;
-
-            ActualMaxValue = max;
-            ActualMinValue = min;
-
             for (int i = 0; i < values.Length; i++)
             {
                 float x = (i + count - values.Length) / (float)(count - 1) * DrawWidth - 1;