Merge branch 'master' into fix-perform-from-menu-nullref

This commit is contained in:
Bartłomiej Dach
2020-12-31 10:33:05 +01:00
2 changed files with 4 additions and 28 deletions

View File

@ -5,9 +5,7 @@
using System; using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Threading;
using Newtonsoft.Json; using Newtonsoft.Json;
using osu.Framework.Allocation;
namespace osu.Game.Online.Multiplayer namespace osu.Game.Online.Multiplayer
{ {
@ -48,27 +46,6 @@ namespace osu.Game.Online.Multiplayer
RoomID = roomId; RoomID = roomId;
} }
private object updateLock = new object();
private ManualResetEventSlim freeForWrite = new ManualResetEventSlim(true);
/// <summary>
/// Request a lock on this room to perform a thread-safe update.
/// </summary>
public IDisposable LockForUpdate()
{
// ReSharper disable once InconsistentlySynchronizedField
freeForWrite.Wait();
lock (updateLock)
{
freeForWrite.Wait();
freeForWrite.Reset();
return new ValueInvokeOnDisposal<MultiplayerRoom>(this, r => freeForWrite.Set());
}
}
public override string ToString() => $"RoomID:{RoomID} Host:{Host?.UserID} Users:{Users.Count} State:{State} Settings: [{Settings}]"; public override string ToString() => $"RoomID:{RoomID} Host:{Host?.UserID} Users:{Users.Count} State:{State} Settings: [{Settings}]";
} }
} }

View File

@ -7,12 +7,11 @@ namespace osu.Game.Overlays.Changelog
{ {
public class ChangelogUpdateStreamControl : OverlayStreamControl<APIUpdateStream> public class ChangelogUpdateStreamControl : OverlayStreamControl<APIUpdateStream>
{ {
protected override OverlayStreamItem<APIUpdateStream> CreateStreamItem(APIUpdateStream value) => new ChangelogUpdateStreamItem(value); public ChangelogUpdateStreamControl()
protected override void LoadComplete()
{ {
// suppress base logic of immediately selecting first item if one exists SelectFirstTabByDefault = false;
// (we always want to start with no stream selected).
} }
protected override OverlayStreamItem<APIUpdateStream> CreateStreamItem(APIUpdateStream value) => new ChangelogUpdateStreamItem(value);
} }
} }