sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-06-08 04:48:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19373 from peppy/fix-negative-star-rating-display

Browse Source 
Fix star ratings which are still being calculated showing as "-1" at song select
This commit is contained in:
Dan Balasescu 2022-07-25 18:20:30 +09:00 committed by GitHub
commit 1d48cee230
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Tests/Visual/UserInterface/TestSceneStarRatingDisplay.cs
View File

@ -29,7 +29,7 @@ namespace osu.Game.Tests.Visual.UserInterface
AutoSizeAxes = Axes.Both, AutoSizeAxes = Axes.Both,
Spacing = new Vector2(2f), Spacing = new Vector2(2f),
Direction = FillDirection.Horizontal, Direction = FillDirection.Horizontal,
ChildrenEnumerable = Enumerable.Range(0, 15).Select(i => new FillFlowContainer ChildrenEnumerable = Enumerable.Range(-1, 15).Select(i => new FillFlowContainer
{ {
Anchor = Anchor.Centre, Anchor = Anchor.Centre,
Origin = Anchor.Centre, Origin = Anchor.Centre,

2
osu.Game/Beatmaps/Drawables/StarRatingDisplay.cs
View File

@ -151,7 +151,7 @@ namespace osu.Game.Beatmaps.Drawables
displayedStars.BindValueChanged(s => displayedStars.BindValueChanged(s =>
{ {
starsText.Text = s.NewValue.ToLocalisableString("0.00"); starsText.Text = s.NewValue < 0 ? "-" : s.NewValue.ToLocalisableString("0.00");
background.Colour = colours.ForStarDifficulty(s.NewValue); background.Colour = colours.ForStarDifficulty(s.NewValue);