sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-04-29 02:37:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix bindable feedback loop

Browse Source
This commit is contained in:
Dean Herbert 2023-05-25 17:57:37 +09:00
parent 8e5ba2208d
commit 1e14b02493
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Screens/Edit/Compose/Components/EditorSelectionHandler.cs
View File

@ -85,6 +85,11 @@ namespace osu.Game.Screens.Edit.Compose.Components
} }
else else
{ {
// Auto should never apply when there is a selection made.
// This is also required to stop a bindable feedback loop when a HitObject has zero samples (and LINQ `All` below becomes true).
if (bankName == HIT_BANK_AUTO)
break;
// Never remove a sample bank. // Never remove a sample bank.
// These are basically radio buttons, not toggles. // These are basically radio buttons, not toggles.
if (SelectedItems.All(h => h.Samples.All(s => s.Bank == bankName))) if (SelectedItems.All(h => h.Samples.All(s => s.Bank == bankName)))