sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 00:40:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Avoid deserialisation JSON request content when error is not present (or not relevant)

Browse Source
This commit is contained in:
Dean Herbert
2021-07-28 20:13:40 +09:00
parent 2b107d624a
commit 1ed4fdd5f5
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Online/API/APIRequest.cs
View File

@ -171,9 +171,13 @@ namespace osu.Game.Online.API
WebRequest?.Abort(); WebRequest?.Abort();
// in the case of a cancellation we don't care about whether there's an error in the response.
if (!(e is OperationCanceledException))
{
string responseString = WebRequest?.GetResponseString(); string responseString = WebRequest?.GetResponseString();
if (!string.IsNullOrEmpty(responseString)) // naive check whether there's an error in the response to avoid unnecessary JSON deserialisation.
if (!string.IsNullOrEmpty(responseString) && responseString.Contains(@"""error"""))
{ {
try try
{ {
@ -186,6 +190,7 @@ namespace osu.Game.Online.API
{ {
} }
} }
}
Logger.Log($@"Failing request {this} ({e})", LoggingTarget.Network); Logger.Log($@"Failing request {this} ({e})", LoggingTarget.Network);
pendingFailure = () => TriggerFailure(e); pendingFailure = () => TriggerFailure(e);