sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-07 00:23:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12392 from peppy/avoid-score-online-id-conflicts

Browse Source 
Don't store online IDs from score submission responses for now
This commit is contained in:
Dan Balasescu
2021-04-13 15:40:03 +09:00
committed by GitHub
parent 20e84f14e6 273099d53c
commit 20a432c083
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Screens/Play/SubmittingPlayer.cs
View File

@ -109,7 +109,12 @@ namespace osu.Game.Screens.Play
request.Success += s => request.Success += s =>
{ {
score.ScoreInfo.OnlineScoreID = s.ID; // For the time being, online ID responses are not really useful for anything.
// In addition, the IDs provided via new (lazer) endpoints are based on a different autoincrement from legacy (stable) scores.
//
// Until we better define the server-side logic behind this, let's not store the online ID to avoid potential unique constraint
// conflicts across various systems (ie. solo and multiplayer).
// score.ScoreInfo.OnlineScoreID = s.ID;
tcs.SetResult(true); tcs.SetResult(true);
}; };