Rename variables to remove redundant "screen" terminology

This commit is contained in:
Dean Herbert
2019-06-12 16:33:15 +09:00
parent a9c229b1ec
commit 20b43c20c8
6 changed files with 26 additions and 27 deletions

View File

@ -56,25 +56,25 @@ namespace osu.Game.Screens
/// <summary>
/// The <see cref="UserActivity"/> to set the user's activity automatically to when this screen is entered
/// <para>This <see cref="ScreenActivity"/> will be automatically set to <see cref="InitialScreenActivity"/> for this screen on entering unless
/// <see cref="ScreenActivity"/> is manually set before.</para>
/// <para>This <see cref="Activity"/> will be automatically set to <see cref="InitialActivity"/> for this screen on entering unless
/// <see cref="Activity"/> is manually set before.</para>
/// </summary>
protected virtual UserActivity InitialScreenActivity => null;
protected virtual UserActivity InitialActivity => null;
private UserActivity screenActivity;
private UserActivity activity;
/// <summary>
/// The <see cref="UserActivity"/> for this screen.
/// The current <see cref="UserActivity"/> for this screen.
/// </summary>
protected UserActivity ScreenActivity
protected UserActivity Activity
{
get => screenActivity;
get => activity;
set
{
if (value == screenActivity) return;
if (value == activity) return;
screenActivity = value;
setUserActivity(screenActivity);
activity = value;
updateActivity();
}
}
@ -152,7 +152,7 @@ namespace osu.Game.Screens
sampleExit?.Play();
applyArrivingDefaults(true);
setUserActivity(screenActivity);
updateActivity();
base.OnResuming(last);
}
@ -170,8 +170,8 @@ namespace osu.Game.Screens
backgroundStack?.Push(localBackground = CreateBackground());
if (screenActivity == null)
ScreenActivity = InitialScreenActivity;
if (activity == null)
Activity = InitialActivity;
base.OnEntering(last);
}
@ -190,11 +190,10 @@ namespace osu.Game.Screens
return false;
}
private void setUserActivity(UserActivity activity)
private void updateActivity()
{
if (api == null) return;
api.LocalUser.Value.Activity.Value = activity;
if (api != null)
api.LocalUser.Value.Activity.Value = activity;
}
/// <summary>