From 26337dbcd8c7ca314cf0a8034ee2a6cdad9058b5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Thu, 4 May 2023 18:26:45 +0200
Subject: [PATCH] Do not rely on unspecified `Dictionary.Values` ordering

---
 osu.Game/Rulesets/Mods/Mod.cs | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Rulesets/Mods/Mod.cs b/osu.Game/Rulesets/Mods/Mod.cs
index cf5a1c6fcc..db7e7ce8e3 100644
--- a/osu.Game/Rulesets/Mods/Mod.cs
+++ b/osu.Game/Rulesets/Mods/Mod.cs
@@ -119,7 +119,11 @@ namespace osu.Game.Rulesets.Mods
         /// <summary>
         /// All <see cref="IBindable"/> settings within this mod.
         /// </summary>
-        internal IEnumerable<IBindable> SettingsBindables => Settings.Values;
+        /// <remarks>
+        /// The settings are returned in ascending key order as per <see cref="Settings"/>.
+        /// The ordering is intentionally enforced manually, as ordering of <see cref="Dictionary{TKey,TValue}.Values"/> is unspecified.
+        /// </remarks>
+        internal IEnumerable<IBindable> SettingsBindables => Settings.OrderBy(pair => pair.Key).Select(pair => pair.Value);
 
         /// <summary>
         /// Provides mapping of names to <see cref="IBindable"/>s of all settings within this mod.