sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-08 09:03:50 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'master' into fix-editor-samples-not-pausing-screen-swap

Browse Source
This commit is contained in:
Dan Balasescu
2020-10-27 21:29:16 +09:00
committed by GitHub
parent d148bafedc df5348cd93
commit 26a7545534
3 changed files with 12 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Rulesets/UI/FrameStabilityContainer.cs
View File

@ -197,9 +197,11 @@ namespace osu.Game.Rulesets.UI
manualClock.Rate = Math.Abs(parentGameplayClock.Rate) * direction; manualClock.Rate = Math.Abs(parentGameplayClock.Rate) * direction;
manualClock.IsRunning = parentGameplayClock.IsRunning; manualClock.IsRunning = parentGameplayClock.IsRunning;
requireMoreUpdateLoops |= manualClock.CurrentTime != parentGameplayClock.CurrentTime; double timeBehind = Math.Abs(manualClock.CurrentTime - parentGameplayClock.CurrentTime);
frameStableClock.IsCatchingUp.Value = requireMoreUpdateLoops; requireMoreUpdateLoops |= timeBehind != 0;
frameStableClock.IsCatchingUp.Value = timeBehind > 200;
// The manual clock time has changed in the above code. The framed clock now needs to be updated // The manual clock time has changed in the above code. The framed clock now needs to be updated
// to ensure that the its time is valid for our children before input is processed // to ensure that the its time is valid for our children before input is processed

9
osu.Game/Screens/Edit/Timing/ControlPointTable.cs
View File

@ -177,6 +177,9 @@ namespace osu.Game.Screens.Edit.Timing
private readonly Box hoveredBackground; private readonly Box hoveredBackground;
[Resolved]
private EditorClock clock { get; set; }
[Resolved] [Resolved]
private Bindable<ControlPointGroup> selectedGroup { get; set; } private Bindable<ControlPointGroup> selectedGroup { get; set; }
@ -200,7 +203,11 @@ namespace osu.Game.Screens.Edit.Timing
}, },
}; };
Action = () => selectedGroup.Value = controlGroup; Action = () =>
{
selectedGroup.Value = controlGroup;
clock.SeekTo(controlGroup.Time);
};
} }
private Color4 colourHover; private Color4 colourHover;

14
osu.Game/Screens/Edit/Timing/TimingScreen.cs
View File

@ -22,9 +22,6 @@ namespace osu.Game.Screens.Edit.Timing
[Cached] [Cached]
private Bindable<ControlPointGroup> selectedGroup = new Bindable<ControlPointGroup>(); private Bindable<ControlPointGroup> selectedGroup = new Bindable<ControlPointGroup>();
[Resolved]
private EditorClock clock { get; set; }
public TimingScreen() public TimingScreen()
: base(EditorScreenMode.Timing) : base(EditorScreenMode.Timing)
{ {
@ -48,17 +45,6 @@ namespace osu.Game.Screens.Edit.Timing
} }
}; };
protected override void LoadComplete()
{
base.LoadComplete();
selectedGroup.BindValueChanged(selected =>
{
if (selected.NewValue != null)
clock.SeekTo(selected.NewValue.Time);
});
}
protected override void OnTimelineLoaded(TimelineArea timelineArea) protected override void OnTimelineLoaded(TimelineArea timelineArea)
{ {
base.OnTimelineLoaded(timelineArea); base.OnTimelineLoaded(timelineArea);