sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-30 01:47:30 +09:00
Code Issues Packages Projects Releases Wiki Activity

Simplify implementation

Browse Source
This commit is contained in:
Dean Herbert 2019-09-03 19:20:23 +09:00
parent e88965b433
commit 299d528654
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Graphics/UserInterface/HoverClickSounds.cs
View File

@ -36,11 +36,9 @@ namespace osu.Game.Graphics.UserInterface
protected override bool OnMouseUp(MouseUpEvent e) protected override bool OnMouseUp(MouseUpEvent e)
{ {
bool shouldPlayEffect = buttons.Contains(e.Button); if (buttons.Contains(e.Button) && Contains(e.ScreenSpaceMousePosition))
// examine the button pressed first for short-circuiting
// in most usages it is more likely that another button was pressed than that the cursor left the drawable bounds
if (shouldPlayEffect && Contains(e.ScreenSpaceMousePosition))
sampleClick?.Play(); sampleClick?.Play();
return base.OnMouseUp(e); return base.OnMouseUp(e);
} }