sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 16:13:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Use a more correct CompareTo implementation for ruleset ordering

Browse Source
This commit is contained in:
Dean Herbert
2022-01-27 21:58:04 +09:00
parent 33b7bdcf82
commit 2d1a8a9d49
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Rulesets/RulesetInfo.cs
View File

@ -51,14 +51,14 @@ namespace osu.Game.Rulesets
public int CompareTo(RulesetInfo other) public int CompareTo(RulesetInfo other)
{ {
if (OnlineID >= 0 && other.OnlineID >= 0)
return OnlineID.CompareTo(other.OnlineID);
// Official rulesets are always given precedence for the time being. // Official rulesets are always given precedence for the time being.
if (OnlineID >= 0) if (OnlineID >= 0)
{
if (other.OnlineID >= 0)
return OnlineID.CompareTo(other.OnlineID);
return -1; return -1;
} if (other.OnlineID >= 0)
return 1;
return string.Compare(ShortName, other.ShortName, StringComparison.Ordinal); return string.Compare(ShortName, other.ShortName, StringComparison.Ordinal);
} }