sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 16:59:53 +09:00
Code Issues Packages Projects Releases Wiki Activity

SpawnParticle -> CreateParticle (and set time outside of virtual call)

Browse Source 
Allows easier overriding (no need to call the `base.CreateParticle` call
and worry about overwriting the time value.
This commit is contained in:
Dean Herbert
2021-09-16 16:50:03 +09:00
parent 29ce2f05bd
commit 2df4073946
3 changed files with 35 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Graphics/ParticleSpewer.cs
View File

@ -53,7 +53,10 @@ namespace osu.Game.Graphics
if (Active.Value && CanSpawnParticles && Time.Current > lastParticleAdded + cooldown)
{
particles[currentIndex] = SpawnParticle();
var newParticle = CreateParticle();
newParticle.StartTime = (float)Time.Current;
particles[currentIndex] = newParticle;
currentIndex = (currentIndex + 1) % particles.Length;
lastParticleAdded = Time.Current;
@ -65,13 +68,7 @@ namespace osu.Game.Graphics
/// <summary>
/// Called each time a new particle should be spawned.
/// </summary>
protected virtual FallingParticle SpawnParticle()
{
return new FallingParticle
{
StartTime = (float)Time.Current,
};
}
protected virtual FallingParticle CreateParticle() => new FallingParticle();
protected override DrawNode CreateDrawNode() => new ParticleSpewerDrawNode(this);