sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 16:59:53 +09:00
Code Issues Packages Projects Releases Wiki Activity

Avoid API change to DrawableHitObject

Browse Source
This commit is contained in:
Dean Herbert
2020-09-24 13:28:29 +09:00
parent 156edf24c2
commit 33fad27ec2
5 changed files with 17 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -126,7 +126,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
if (Result == null)
throw new InvalidOperationException($"{GetType().ReadableName()} must provide a {nameof(JudgementResult)} through {nameof(CreateResult)}.");
LoadSamples(false);
LoadSamples();
}
protected override void LoadAsyncComplete()
@ -145,7 +145,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
}
samplesBindable = HitObject.SamplesBindable.GetBoundCopy();
samplesBindable.CollectionChanged += (_, __) => LoadSamples(true);
samplesBindable.CollectionChanged += (_, __) => LoadSamples();
apply(HitObject);
}
@ -160,8 +160,7 @@ namespace osu.Game.Rulesets.Objects.Drawables
/// <summary>
/// Invoked by the base <see cref="DrawableHitObject"/> to populate samples, once on initial load and potentially again on any change to the samples collection.
/// </summary>
/// <param name="changed">True if triggered from a change to the samples collection.</param>
protected virtual void LoadSamples(bool changed)
protected virtual void LoadSamples()
{
if (Samples != null)
{