sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-04-29 02:37:25 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix upwards scroll direction not working with recent hold note display changes

Browse Source
This commit is contained in:
Dean Herbert 2023-03-03 18:03:06 +09:00
parent 29be26b150
commit 36058b3da2
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs
View File

@ -167,8 +167,8 @@ namespace osu.Game.Rulesets.Mania.Skinning.Legacy
{ {
if (bodySprite != null) if (bodySprite != null)
{ {
bodySprite.Origin = Anchor.BottomCentre; bodySprite.Origin = Anchor.TopCentre;
bodySprite.Scale = new Vector2(bodySprite.Scale.X, Math.Abs(bodySprite.Scale.Y) * -1); bodySprite.Anchor = Anchor.BottomCentre; // needs to be flipped due to scale flip in Update.
} }
if (light != null) if (light != null)
@ -179,7 +179,7 @@ namespace osu.Game.Rulesets.Mania.Skinning.Legacy
if (bodySprite != null) if (bodySprite != null)
{ {
bodySprite.Origin = Anchor.TopCentre; bodySprite.Origin = Anchor.TopCentre;
bodySprite.Scale = new Vector2(bodySprite.Scale.X, Math.Abs(bodySprite.Scale.Y)); bodySprite.Anchor = Anchor.TopCentre;
} }
if (light != null) if (light != null)
@ -211,11 +211,15 @@ namespace osu.Game.Rulesets.Mania.Skinning.Legacy
base.Update(); base.Update();
missFadeTime.Value ??= holdNote.HoldBrokenTime; missFadeTime.Value ??= holdNote.HoldBrokenTime;
int scaleDirection = (direction.Value == ScrollingDirection.Down ? 1 : -1);
// here we go... // here we go...
switch (bodyStyle) switch (bodyStyle)
{ {
case LegacyNoteBodyStyle.Stretch: case LegacyNoteBodyStyle.Stretch:
// this is how lazer works by default. nothing required. // this is how lazer works by default. nothing required.
if (bodySprite != null)
bodySprite.Scale = new Vector2(1, scaleDirection);
break; break;
default: default:
@ -228,7 +232,7 @@ namespace osu.Game.Rulesets.Mania.Skinning.Legacy
bodySprite.FillMode = FillMode.Stretch; bodySprite.FillMode = FillMode.Stretch;
// i dunno this looks about right?? // i dunno this looks about right??
bodySprite.Scale = new Vector2(1, 32800 / sprite.DrawHeight); bodySprite.Scale = new Vector2(1, scaleDirection * 32800 / sprite.DrawHeight);
} }
break; break;