diff --git a/osu.Desktop.VisualTests/Tests/TestCaseTaikoHitObjects.cs b/osu.Desktop.VisualTests/Tests/TestCaseTaikoHitObjects.cs index dddc487bd6..02f98edc97 100644 --- a/osu.Desktop.VisualTests/Tests/TestCaseTaikoHitObjects.cs +++ b/osu.Desktop.VisualTests/Tests/TestCaseTaikoHitObjects.cs @@ -62,20 +62,16 @@ namespace osu.Desktop.VisualTests.Tests Position = new Vector2(350, 300) }); - Add(new SwellCirclePiece(new CirclePiece + Add(new CirclePiece { - KiaiMode = kiai - }) - { - Position = new Vector2(100, 500) - }); - - Add(new SwellCirclePiece(new StrongCirclePiece - { - KiaiMode = kiai - }) - { - Position = new Vector2(350, 500) + Position = new Vector2(100, 500), + Width = 0, + AccentColour = Color4.Orange, + KiaiMode = kiai, + Children = new[] + { + new SwellSymbolPiece() + } }); Add(new DrumRollCircle(new CirclePiece() diff --git a/osu.Game.Modes.Taiko/Objects/Drawable/DrawableSwell.cs b/osu.Game.Modes.Taiko/Objects/Drawable/DrawableSwell.cs index 242159446a..291e1df837 100644 --- a/osu.Game.Modes.Taiko/Objects/Drawable/DrawableSwell.cs +++ b/osu.Game.Modes.Taiko/Objects/Drawable/DrawableSwell.cs @@ -41,6 +41,8 @@ namespace osu.Game.Modes.Taiko.Objects.Drawable private readonly CircularContainer targetRing; private readonly CircularContainer innerRing; + private readonly CirclePiece circlePiece; + private bool hasStarted; public DrawableSwell(Swell swell) @@ -107,7 +109,13 @@ namespace osu.Game.Modes.Taiko.Objects.Drawable } } }, - new SwellCirclePiece(new CirclePiece()) + circlePiece = new CirclePiece + { + Children = new [] + { + new SwellSymbolPiece() + } + } } } }; @@ -116,6 +124,7 @@ namespace osu.Game.Modes.Taiko.Objects.Drawable [BackgroundDependencyLoader] private void load(OsuColour colours) { + circlePiece.AccentColour = colours.YellowDark; innerRing.Colour = colours.YellowDark; targetRing.BorderColour = colours.YellowDark.Opacity(0.25f); } diff --git a/osu.Game.Modes.Taiko/Objects/Drawable/Pieces/SwellCirclePiece.cs b/osu.Game.Modes.Taiko/Objects/Drawable/Pieces/SwellCirclePiece.cs deleted file mode 100644 index 8274a2bff0..0000000000 --- a/osu.Game.Modes.Taiko/Objects/Drawable/Pieces/SwellCirclePiece.cs +++ /dev/null @@ -1,35 +0,0 @@ -// Copyright (c) 2007-2017 ppy Pty Ltd . -// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE - -using osu.Framework.Graphics; -using osu.Framework.Allocation; -using osu.Framework.Graphics.Containers; -using osu.Game.Graphics; - -namespace osu.Game.Modes.Taiko.Objects.Drawable.Pieces -{ - public class SwellCirclePiece : Container - { - private readonly CirclePiece circle; - - public SwellCirclePiece(CirclePiece piece) - { - Add(circle = piece); - - circle.Add(new TextAwesome - { - Anchor = Anchor.Centre, - Origin = Anchor.Centre, - TextSize = CirclePiece.SYMBOL_INNER_SIZE, - Icon = FontAwesome.fa_asterisk, - Shadow = false - }); - } - - [BackgroundDependencyLoader] - private void load(OsuColour colours) - { - circle.AccentColour = colours.YellowDark; - } - } -} diff --git a/osu.Game.Modes.Taiko/Objects/Drawable/Pieces/SwellSymbolPiece.cs b/osu.Game.Modes.Taiko/Objects/Drawable/Pieces/SwellSymbolPiece.cs new file mode 100644 index 0000000000..ba7f5b8df9 --- /dev/null +++ b/osu.Game.Modes.Taiko/Objects/Drawable/Pieces/SwellSymbolPiece.cs @@ -0,0 +1,23 @@ +// Copyright (c) 2007-2017 ppy Pty Ltd . +// Licensed under the MIT Licence - https://raw.githubusercontent.com/ppy/osu/master/LICENCE + +using osu.Game.Graphics; +using osu.Framework.Graphics; + +namespace osu.Game.Modes.Taiko.Objects.Drawable.Pieces +{ + /// + /// The symbol used for swell pieces. + /// + public class SwellSymbolPiece : TextAwesome + { + public SwellSymbolPiece() + { + Anchor = Anchor.Centre; + Origin = Anchor.Centre; + TextSize = CirclePiece.SYMBOL_INNER_SIZE; + Icon = FontAwesome.fa_asterisk; + Shadow = false; + } + } +} diff --git a/osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj b/osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj index 2e9034839f..d3d7143baa 100644 --- a/osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj +++ b/osu.Game.Modes.Taiko/osu.Game.Modes.Taiko.csproj @@ -58,9 +58,9 @@ - + @@ -103,4 +103,4 @@ --> - + \ No newline at end of file