sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-02 20:27:27 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix undo not behaving as expected sometimes

Browse Source
This commit is contained in:
Bartłomiej Dach 2023-05-22 22:45:39 +02:00
parent e0b7539c2a
commit 38b4bd8aef
No known key found for this signature in database
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Screens/Edit/LegacyEditorBeatmapPatcher.cs
View File

@ -108,6 +108,11 @@ namespace osu.Game.Screens.Edit
foreach (var (oldObject, newObject) in oldObjects.Zip(newObjects)) foreach (var (oldObject, newObject) in oldObjects.Zip(newObjects))
{ {
// if `oldObject` and `newObject` are the same, it means that `oldObject` was inserted into `editorBeatmap` by `processHitObjects()`.
// in that case, there is nothing to do (and some of the subsequent changes may even prove destructive).
if (ReferenceEquals(oldObject, newObject))
continue;
if (oldObject is IHasSliderVelocity oldWithVelocity && newObject is IHasSliderVelocity newWithVelocity) if (oldObject is IHasSliderVelocity oldWithVelocity && newObject is IHasSliderVelocity newWithVelocity)
oldWithVelocity.SliderVelocity = newWithVelocity.SliderVelocity; oldWithVelocity.SliderVelocity = newWithVelocity.SliderVelocity;