Merge pull request #10286 from peppy/fix-hitobject-sample-stuck-on-future-seek

Fix HitObject samples getting stuck in a playing state on seeking far into the future
This commit is contained in:
Dan Balasescu
2020-10-01 18:08:17 +09:00
committed by GitHub
5 changed files with 74 additions and 1 deletions

View File

@ -384,6 +384,11 @@ namespace osu.Game.Rulesets.Objects.Drawables
}
}
/// <summary>
/// Stops playback of all samples. Automatically called when <see cref="DrawableHitObject{TObject}"/>'s lifetime has been exceeded.
/// </summary>
public virtual void StopAllSamples() => Samples?.Stop();
protected override void Update()
{
base.Update();
@ -452,6 +457,8 @@ namespace osu.Game.Rulesets.Objects.Drawables
foreach (var nested in NestedHitObjects)
nested.OnKilled();
StopAllSamples();
UpdateResult(false);
}