sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-31 10:27:26 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix hold note end time being written incorrectly

Browse Source
This commit is contained in:
smoogipoo 2020-04-22 16:40:07 +09:00
parent 7cdc9a599c
commit 3b805daa0b
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
View File

@ -240,8 +240,9 @@ namespace osu.Game.Beatmaps.Formats
} }
else else
{ {
if (hitObject is IHasEndTime endTimeData) if (hitObject is IHasEndTime _)
writer.Write(FormattableString.Invariant($"{endTimeData.EndTime},")); addEndTimeData(writer, hitObject);
writer.Write(getSampleBank(hitObject.Samples)); writer.Write(getSampleBank(hitObject.Samples));
} }
@ -344,6 +345,20 @@ namespace osu.Game.Beatmaps.Formats
} }
} }
private void addEndTimeData(TextWriter writer, HitObject hitObject)
{
var endTimeData = (IHasEndTime)hitObject;
var type = getObjectType(hitObject);
char suffix = ',';
// Holds write the end time as if it's part of sample data.
if (type == LegacyHitObjectType.Hold)
suffix = ':';
writer.Write(FormattableString.Invariant($"{endTimeData.EndTime}{suffix}"));
}
private string getSampleBank(IList<HitSampleInfo> samples, bool banksOnly = false, bool zeroBanks = false) private string getSampleBank(IList<HitSampleInfo> samples, bool banksOnly = false, bool zeroBanks = false)
{ {
LegacySampleBank normalBank = toLegacySampleBank(samples.SingleOrDefault(s => s.Name == HitSampleInfo.HIT_NORMAL)?.Bank); LegacySampleBank normalBank = toLegacySampleBank(samples.SingleOrDefault(s => s.Name == HitSampleInfo.HIT_NORMAL)?.Bank);