sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 15:44:04 +09:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary loading hide call from PlaceholderState_Set and add more assertiveness

Browse Source
This commit is contained in:
Dean Herbert
2022-01-30 02:34:31 +09:00
parent 51acf79935
commit 3d771c0fc7
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Online/Leaderboards/Leaderboard.cs
View File

@ -241,9 +241,11 @@ namespace osu.Game.Online.Leaderboards
if (value == placeholderState) if (value == placeholderState)
return; return;
loading.Hide(); placeholderState = value;
switch (placeholderState = value) Debug.Assert(placeholderState != PlaceholderState.Successful || scores?.Any() == true);
switch (placeholderState)
{ {
case PlaceholderState.NetworkFailure: case PlaceholderState.NetworkFailure:
replacePlaceholder(new ClickablePlaceholder(@"Couldn't fetch scores!", FontAwesome.Solid.Sync) replacePlaceholder(new ClickablePlaceholder(@"Couldn't fetch scores!", FontAwesome.Solid.Sync)