sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-06 16:13:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #22535 from peppy/forcefully-stop-pause-sample

Browse Source 
Ensure pause sample loop is stopped on exiting player
This commit is contained in:
Bartłomiej Dach
2023-02-06 19:51:51 +01:00
committed by GitHub
parent c078d3a344 aaf3ad805c
commit 3ee771cbef
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/Play/PauseOverlay.cs
View File

@ -44,6 +44,14 @@ namespace osu.Game.Screens.Play
}); });
} }
public void StopAllSamples()
{
if (!IsLoaded)
return;
pauseLoop.Stop();
}
protected override void PopIn() protected override void PopIn()
{ {
base.PopIn(); base.PopIn();

3
osu.Game/Screens/Play/Player.cs
View File

@ -1073,7 +1073,10 @@ namespace osu.Game.Screens.Play
public override bool OnExiting(ScreenExitEvent e) public override bool OnExiting(ScreenExitEvent e)
{ {
screenSuspension?.RemoveAndDisposeImmediately(); screenSuspension?.RemoveAndDisposeImmediately();
// Eagerly clean these up as disposal of child components is asynchronous and may leave sounds playing beyond user expectations.
failAnimationLayer?.Stop(); failAnimationLayer?.Stop();
PauseOverlay?.StopAllSamples();
if (LoadedBeatmapSuccessfully) if (LoadedBeatmapSuccessfully)
{ {