sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-03 01:09:57 +09:00
Code Issues Packages Projects Releases Wiki Activity

Fix hacky tabs

Browse Source
This commit is contained in:
Dean Herbert
2017-06-12 18:39:22 +09:00
parent 8bd9c112ba
commit 3efe8629d6
4 changed files with 35 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
osu.Game/Overlays/Chat/ChatTabControl.cs
View File

@ -26,6 +26,8 @@ namespace osu.Game.Overlays.Chat
public readonly Bindable<bool> ChannelSelectorActive = new Bindable<bool>();
private readonly ChannelTabItem.ChannelSelectorTabItem selectorTab;
public ChatTabControl()
{
TabContainer.Margin = new MarginPadding { Left = 50 };
@ -41,7 +43,22 @@ namespace osu.Game.Overlays.Chat
Padding = new MarginPadding(10),
});
AddTabItem(new ChannelTabItem.ChannelSelectorTabItem(new Channel { Name = "+" }, ChannelSelectorActive));
AddTabItem(selectorTab = new ChannelTabItem.ChannelSelectorTabItem(new Channel { Name = "+" }));
ChannelSelectorActive.BindTo(selectorTab.Active);
}
protected override void SelectTab(TabItem<Channel> tab)
{
if (tab is ChannelTabItem.ChannelSelectorTabItem)
{
tab.Active.Toggle();
return;
}
selectorTab.Active.Value = false;
base.SelectTab(tab);
}
private class ChannelTabItem : TabItem<Channel>
@ -56,18 +73,6 @@ namespace osu.Game.Overlays.Chat
private readonly Box highlightBox;
private readonly TextAwesome icon;
public override bool Active
{
get { return base.Active; }
set
{
if (Active == value) return;
base.Active = value;
updateState();
}
}
private void updateState()
{
if (Active)
@ -205,28 +210,8 @@ namespace osu.Game.Overlays.Chat
public class ChannelSelectorTabItem : ChannelTabItem
{
public override bool Active
public ChannelSelectorTabItem(Channel value) : base(value)
{
get { return false; }
// ReSharper disable once ValueParameterNotUsed
set
{
// we basically never want this tab to become active.
// this allows us to become a "toggle" tab.
// is a bit hacky, to say the least.
activeBindable.Value = !activeBindable.Value;
base.Active = false;
}
}
private readonly Bindable<bool> activeBindable;
public ChannelSelectorTabItem(Channel value, Bindable<bool> active) : base(value)
{
activeBindable = active;
activeBindable.ValueChanged += v => selectorUpdateState();
Depth = float.MaxValue;
Width = 45;
@ -242,27 +227,11 @@ namespace osu.Game.Overlays.Chat
backgroundInactive = colour.Gray2;
backgroundActive = colour.Gray3;
}
protected override void LoadComplete()
{
base.LoadComplete();
selectorUpdateState();
}
protected override void OnHoverLost(InputState state)
{
selectorUpdateState();
}
private void selectorUpdateState()
{
if (activeBindable.Value)
fadeActive();
else
fadeInactive();
}
}
protected override void OnActivated() => updateState();
protected override void OnDeactivated() => updateState();
}
}
}