sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-05-17 03:27:21 +09:00
Code Issues Packages Projects Releases Wiki Activity

Rename to StartTimeChanged and add xmldocs

Browse Source
This commit is contained in:
smoogipoo 2019-10-03 14:37:16 +09:00
parent f2719afd0e
commit 3fb0b0b668
2 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game.Tests/Beatmaps/EditorBeatmapTest.cs
View File

@ -58,7 +58,7 @@ namespace osu.Game.Tests.Beatmaps
var editorBeatmap = new EditorBeatmap<OsuHitObject>(new OsuBeatmap { HitObjects = { hitCircle } }); var editorBeatmap = new EditorBeatmap<OsuHitObject>(new OsuBeatmap { HitObjects = { hitCircle } });
HitObject changedObject = null; HitObject changedObject = null;
editorBeatmap.HitObjectChanged += h => changedObject = h; editorBeatmap.StartTimeChanged += h => changedObject = h;
hitCircle.StartTime = 1000; hitCircle.StartTime = 1000;
Assert.That(changedObject, Is.EqualTo(hitCircle)); Assert.That(changedObject, Is.EqualTo(hitCircle));
@ -74,7 +74,7 @@ namespace osu.Game.Tests.Beatmaps
var editorBeatmap = new EditorBeatmap<OsuHitObject>(new OsuBeatmap()); var editorBeatmap = new EditorBeatmap<OsuHitObject>(new OsuBeatmap());
HitObject changedObject = null; HitObject changedObject = null;
editorBeatmap.HitObjectChanged += h => changedObject = h; editorBeatmap.StartTimeChanged += h => changedObject = h;
var hitCircle = new HitCircle(); var hitCircle = new HitCircle();
@ -95,7 +95,7 @@ namespace osu.Game.Tests.Beatmaps
var editorBeatmap = new EditorBeatmap<OsuHitObject>(new OsuBeatmap { HitObjects = { hitCircle } }); var editorBeatmap = new EditorBeatmap<OsuHitObject>(new OsuBeatmap { HitObjects = { hitCircle } });
HitObject changedObject = null; HitObject changedObject = null;
editorBeatmap.HitObjectChanged += h => changedObject = h; editorBeatmap.StartTimeChanged += h => changedObject = h;
editorBeatmap.Remove(hitCircle); editorBeatmap.Remove(hitCircle);
Assert.That(changedObject, Is.Null); Assert.That(changedObject, Is.Null);

15
osu.Game/Screens/Edit/EditorBeatmap.cs
View File

@ -14,9 +14,20 @@ namespace osu.Game.Screens.Edit
public class EditorBeatmap<T> : IEditorBeatmap<T> public class EditorBeatmap<T> : IEditorBeatmap<T>
where T : HitObject where T : HitObject
{ {
/// <summary>
/// Invoked when a <see cref="HitObject"/> is added to this <see cref="EditorBeatmap{T}"/>.
/// </summary>
public event Action<HitObject> HitObjectAdded; public event Action<HitObject> HitObjectAdded;
/// <summary>
/// Invoked when a <see cref="HitObject"/> is removed from this <see cref="EditorBeatmap{T}"/>.
/// </summary>
public event Action<HitObject> HitObjectRemoved; public event Action<HitObject> HitObjectRemoved;
public event Action<HitObject> HitObjectChanged;
/// <summary>
/// Invoked when the start time of a <see cref="HitObject"/> in this <see cref="EditorBeatmap{T}"/> was changed.
/// </summary>
public event Action<HitObject> StartTimeChanged;
private readonly Dictionary<T, Bindable<double>> startTimeBindables = new Dictionary<T, Bindable<double>>(); private readonly Dictionary<T, Bindable<double>> startTimeBindables = new Dictionary<T, Bindable<double>>();
private readonly Beatmap<T> beatmap; private readonly Beatmap<T> beatmap;
@ -93,7 +104,7 @@ namespace osu.Game.Screens.Edit
var insertionIndex = beatmap.HitObjects.FindLastIndex(h => h.StartTime <= hitObject.StartTime); var insertionIndex = beatmap.HitObjects.FindLastIndex(h => h.StartTime <= hitObject.StartTime);
beatmap.HitObjects.Insert(insertionIndex + 1, hitObject); beatmap.HitObjects.Insert(insertionIndex + 1, hitObject);
HitObjectChanged?.Invoke(hitObject); StartTimeChanged?.Invoke(hitObject);
}; };
} }