diff --git a/CodeAnalysis/osu.ruleset b/CodeAnalysis/osu.ruleset
index 0ec2f24797..d497365f87 100644
--- a/CodeAnalysis/osu.ruleset
+++ b/CodeAnalysis/osu.ruleset
@@ -17,7 +17,6 @@
-
diff --git a/osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs b/osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs
index 0db6498c12..2da5a9c403 100644
--- a/osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs
+++ b/osu.Game.Rulesets.Taiko/Objects/Drawables/DrawableTaikoHitObject.cs
@@ -105,19 +105,19 @@ namespace osu.Game.Rulesets.Taiko.Objects.Drawables
}
}
- public abstract class DrawableTaikoHitObject : DrawableTaikoHitObject
- where TaikoHitType : TaikoHitObject
+ public abstract class DrawableTaikoHitObject : DrawableTaikoHitObject
+ where TTaikoHit : TaikoHitObject
{
public override Vector2 OriginPosition => new Vector2(DrawHeight / 2);
- public new TaikoHitType HitObject;
+ public new TTaikoHit HitObject;
protected readonly Vector2 BaseSize;
protected readonly TaikoPiece MainPiece;
private readonly Container strongHitContainer;
- protected DrawableTaikoHitObject(TaikoHitType hitObject)
+ protected DrawableTaikoHitObject(TTaikoHit hitObject)
: base(hitObject)
{
HitObject = hitObject;
diff --git a/osu.Game/Database/MutableDatabaseBackedStoreWithFileIncludes.cs b/osu.Game/Database/MutableDatabaseBackedStoreWithFileIncludes.cs
index 5d6ff6b09b..102081cd65 100644
--- a/osu.Game/Database/MutableDatabaseBackedStoreWithFileIncludes.cs
+++ b/osu.Game/Database/MutableDatabaseBackedStoreWithFileIncludes.cs
@@ -7,9 +7,9 @@ using osu.Framework.Platform;
namespace osu.Game.Database
{
- public abstract class MutableDatabaseBackedStoreWithFileIncludes : MutableDatabaseBackedStore
- where T : class, IHasPrimaryKey, ISoftDelete, IHasFiles
- where U : INamedFileInfo
+ public abstract class MutableDatabaseBackedStoreWithFileIncludes : MutableDatabaseBackedStore
+ where T : class, IHasPrimaryKey, ISoftDelete, IHasFiles
+ where TFileInfo : INamedFileInfo
{
protected MutableDatabaseBackedStoreWithFileIncludes(IDatabaseContextFactory contextFactory, Storage storage = null)
: base(contextFactory, storage)
diff --git a/osu.Game/Graphics/UserInterfaceV2/LabelledComponent.cs b/osu.Game/Graphics/UserInterfaceV2/LabelledComponent.cs
index 1819b36667..dd6a902989 100644
--- a/osu.Game/Graphics/UserInterfaceV2/LabelledComponent.cs
+++ b/osu.Game/Graphics/UserInterfaceV2/LabelledComponent.cs
@@ -7,15 +7,15 @@ using osu.Framework.Graphics.UserInterface;
namespace osu.Game.Graphics.UserInterfaceV2
{
- public abstract class LabelledComponent : LabelledDrawable, IHasCurrentValue
- where T : Drawable, IHasCurrentValue
+ public abstract class LabelledComponent : LabelledDrawable, IHasCurrentValue
+ where TDrawable : Drawable, IHasCurrentValue
{
protected LabelledComponent(bool padded)
: base(padded)
{
}
- public Bindable Current
+ public Bindable Current
{
get => Component.Current;
set => Component.Current = value;
diff --git a/osu.Game/IO/Legacy/SerializationReader.cs b/osu.Game/IO/Legacy/SerializationReader.cs
index aeb3ce754d..17cbd19838 100644
--- a/osu.Game/IO/Legacy/SerializationReader.cs
+++ b/osu.Game/IO/Legacy/SerializationReader.cs
@@ -116,13 +116,13 @@ namespace osu.Game.IO.Legacy
}
/// Reads a generic Dictionary from the buffer.
- public IDictionary ReadDictionary()
+ public IDictionary ReadDictionary()
{
int count = ReadInt32();
if (count < 0) return null;
- IDictionary d = new Dictionary();
- for (int i = 0; i < count; i++) d[(T)ReadObject()] = (U)ReadObject();
+ IDictionary d = new Dictionary();
+ for (int i = 0; i < count; i++) d[(TKey)ReadObject()] = (TValue)ReadObject();
return d;
}
diff --git a/osu.Game/IO/Legacy/SerializationWriter.cs b/osu.Game/IO/Legacy/SerializationWriter.cs
index f30e4492af..c75de93bc8 100644
--- a/osu.Game/IO/Legacy/SerializationWriter.cs
+++ b/osu.Game/IO/Legacy/SerializationWriter.cs
@@ -102,7 +102,7 @@ namespace osu.Game.IO.Legacy
}
/// Writes a generic IDictionary to the buffer.
- public void Write(IDictionary d)
+ public void Write(IDictionary d)
{
if (d == null)
{
@@ -112,7 +112,7 @@ namespace osu.Game.IO.Legacy
{
Write(d.Count);
- foreach (KeyValuePair kvp in d)
+ foreach (KeyValuePair kvp in d)
{
WriteObject(kvp.Key);
WriteObject(kvp.Value);
diff --git a/osu.Game/Online/Leaderboards/Leaderboard.cs b/osu.Game/Online/Leaderboards/Leaderboard.cs
index 94c50185da..9c48ebd09b 100644
--- a/osu.Game/Online/Leaderboards/Leaderboard.cs
+++ b/osu.Game/Online/Leaderboards/Leaderboard.cs
@@ -19,7 +19,7 @@ using osuTK.Graphics;
namespace osu.Game.Online.Leaderboards
{
- public abstract class Leaderboard : Container, IOnlineComponent
+ public abstract class Leaderboard : Container, IOnlineComponent
{
private const double fade_duration = 300;
@@ -39,9 +39,9 @@ namespace osu.Game.Online.Leaderboards
protected override Container Content => content;
- private IEnumerable scores;
+ private IEnumerable scores;
- public IEnumerable Scores
+ public IEnumerable Scores
{
get => scores;
set
@@ -288,7 +288,7 @@ namespace osu.Game.Online.Leaderboards
///
/// A callback which should be called when fetching is completed. Scheduling is not required.
/// An responsible for the fetch operation. This will be queued and performed automatically.
- protected abstract APIRequest FetchScores(Action> scoresCallback);
+ protected abstract APIRequest FetchScores(Action> scoresCallback);
private Placeholder currentPlaceholder;
@@ -359,6 +359,6 @@ namespace osu.Game.Online.Leaderboards
}
}
- protected abstract LeaderboardScore CreateDrawableScore(ScoreInfo model, int index);
+ protected abstract LeaderboardScore CreateDrawableScore(TScoreInfo model, int index);
}
}
diff --git a/osu.Game/Overlays/OverlayHeaderTabControl.cs b/osu.Game/Overlays/OverlayHeaderTabControl.cs
index 5b56771dc1..7d0cdad6d8 100644
--- a/osu.Game/Overlays/OverlayHeaderTabControl.cs
+++ b/osu.Game/Overlays/OverlayHeaderTabControl.cs
@@ -12,7 +12,7 @@ namespace osu.Game.Overlays
AccentColour = AccentColour,
};
- private class OverlayHeaderTabItem : OverlayTabItem
+ private class OverlayHeaderTabItem : OverlayTabItem
{
public OverlayHeaderTabItem(string value)
: base(value)
diff --git a/osu.Game/Overlays/OverlayTabControl.cs b/osu.Game/Overlays/OverlayTabControl.cs
index 20649c8a74..4c396eabc1 100644
--- a/osu.Game/Overlays/OverlayTabControl.cs
+++ b/osu.Game/Overlays/OverlayTabControl.cs
@@ -32,7 +32,7 @@ namespace osu.Game.Overlays
foreach (TabItem tabItem in TabContainer)
{
- ((OverlayTabItem)tabItem).AccentColour = value;
+ ((OverlayTabItem)tabItem).AccentColour = value;
}
}
}
@@ -59,9 +59,9 @@ namespace osu.Game.Overlays
protected override Dropdown CreateDropdown() => null;
- protected override TabItem CreateTabItem(T value) => new OverlayTabItem(value);
+ protected override TabItem CreateTabItem(T value) => new OverlayTabItem(value);
- protected class OverlayTabItem : TabItem
+ protected class OverlayTabItem : TabItem
{
private readonly ExpandingBar bar;
@@ -84,7 +84,7 @@ namespace osu.Game.Overlays
}
}
- public OverlayTabItem(U value)
+ public OverlayTabItem(T value)
: base(value)
{
AutoSizeAxes = Axes.X;
diff --git a/osu.Game/Overlays/Settings/SettingsSlider.cs b/osu.Game/Overlays/Settings/SettingsSlider.cs
index 20e08c0cd8..96c0279a7b 100644
--- a/osu.Game/Overlays/Settings/SettingsSlider.cs
+++ b/osu.Game/Overlays/Settings/SettingsSlider.cs
@@ -12,11 +12,11 @@ namespace osu.Game.Overlays.Settings
{
}
- public class SettingsSlider : SettingsItem
- where T : struct, IEquatable, IComparable, IConvertible
- where U : OsuSliderBar, new()
+ public class SettingsSlider : SettingsItem
+ where TValue : struct, IEquatable, IComparable, IConvertible
+ where TSlider : OsuSliderBar, new()
{
- protected override Drawable CreateControl() => new U
+ protected override Drawable CreateControl() => new TSlider
{
Margin = new MarginPadding { Top = 5, Bottom = 5 },
RelativeSizeAxes = Axes.X
@@ -24,14 +24,14 @@ namespace osu.Game.Overlays.Settings
public bool TransferValueOnCommit
{
- get => ((U)Control).TransferValueOnCommit;
- set => ((U)Control).TransferValueOnCommit = value;
+ get => ((TSlider)Control).TransferValueOnCommit;
+ set => ((TSlider)Control).TransferValueOnCommit = value;
}
public float KeyboardStep
{
- get => ((U)Control).KeyboardStep;
- set => ((U)Control).KeyboardStep = value;
+ get => ((TSlider)Control).KeyboardStep;
+ set => ((TSlider)Control).KeyboardStep = value;
}
}
}
diff --git a/osu.Game/Overlays/UserProfileOverlay.cs b/osu.Game/Overlays/UserProfileOverlay.cs
index b5e7b8bedb..a34fc619a8 100644
--- a/osu.Game/Overlays/UserProfileOverlay.cs
+++ b/osu.Game/Overlays/UserProfileOverlay.cs
@@ -165,7 +165,7 @@ namespace osu.Game.Overlays
AccentColour = colours.Seafoam;
}
- private class ProfileTabItem : OverlayTabItem
+ private class ProfileTabItem : OverlayTabItem
{
public ProfileTabItem(ProfileSection value)
: base(value)