sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-07 00:23:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Do not consider replays for "pause on focus lost"

Browse Source 
Replays are not pausable as can be seen in the `canPause` check.
This commit is contained in:
Salman Ahmed
2021-02-06 20:55:55 +03:00
parent c9db0bf886
commit 40ddccf0c7
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Screens/Play/Player.cs
View File

@ -160,7 +160,6 @@ namespace osu.Game.Screens.Play
if (!Mods.Value.Any(m => m is ModAutoplay)) if (!Mods.Value.Any(m => m is ModAutoplay))
PrepareReplay(); PrepareReplay();
// needs to be bound here as the last binding, otherwise cases like starting a replay while not focused causes player to exit, if activity is bound before checks.
gameActive.BindTo(gameBase.IsActive); gameActive.BindTo(gameBase.IsActive);
gameActive.BindValueChanged(_ => updatePauseOnFocusLostState(), true); gameActive.BindValueChanged(_ => updatePauseOnFocusLostState(), true);
} }
@ -267,8 +266,6 @@ namespace osu.Game.Screens.Play
DrawableRuleset.HasReplayLoaded.BindValueChanged(_ => updateGameplayState()); DrawableRuleset.HasReplayLoaded.BindValueChanged(_ => updateGameplayState());
DrawableRuleset.HasReplayLoaded.BindValueChanged(_ => updatePauseOnFocusLostState(), true);
// bind clock into components that require it // bind clock into components that require it
DrawableRuleset.IsPaused.BindTo(GameplayClockContainer.IsPaused); DrawableRuleset.IsPaused.BindTo(GameplayClockContainer.IsPaused);
@ -431,7 +428,7 @@ namespace osu.Game.Screens.Play
private void updatePauseOnFocusLostState() private void updatePauseOnFocusLostState()
{ {
if (!PauseOnFocusLost || DrawableRuleset.HasReplayLoaded.Value || breakTracker.IsBreakTime.Value) if (!PauseOnFocusLost || breakTracker.IsBreakTime.Value)
return; return;
if (gameActive.Value == false) if (gameActive.Value == false)