From 42cd4107a0396d8dd06e2acba1ca4ba659f2dd62 Mon Sep 17 00:00:00 2001
From: Andrei Zavatski <megaman9919@gmail.com>
Date: Thu, 17 Oct 2019 15:04:30 +0300
Subject: [PATCH] Implement CommentVoteRequest and adjust UI

---
 .../Online/API/Requests/CommentVoteRequest.cs | 36 +++++++
 osu.Game/Overlays/Comments/VotePill.cs        | 96 ++++++++++++++-----
 2 files changed, 106 insertions(+), 26 deletions(-)
 create mode 100644 osu.Game/Online/API/Requests/CommentVoteRequest.cs

diff --git a/osu.Game/Online/API/Requests/CommentVoteRequest.cs b/osu.Game/Online/API/Requests/CommentVoteRequest.cs
new file mode 100644
index 0000000000..06a3b1126e
--- /dev/null
+++ b/osu.Game/Online/API/Requests/CommentVoteRequest.cs
@@ -0,0 +1,36 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.IO.Network;
+using osu.Game.Online.API.Requests.Responses;
+using System.Net.Http;
+
+namespace osu.Game.Online.API.Requests
+{
+    public class CommentVoteRequest : APIRequest<CommentBundle>
+    {
+        private readonly long id;
+        private readonly CommentVoteAction action;
+
+        public CommentVoteRequest(long id, CommentVoteAction action)
+        {
+            this.id = id;
+            this.action = action;
+        }
+
+        protected override WebRequest CreateWebRequest()
+        {
+            var req = base.CreateWebRequest();
+            req.Method = action == CommentVoteAction.Vote ? HttpMethod.Post : HttpMethod.Delete;
+            return req;
+        }
+
+        protected override string Target => $@"comments/{id}/vote";
+    }
+
+    public enum CommentVoteAction
+    {
+        Vote,
+        UnVote
+    }
+}
diff --git a/osu.Game/Overlays/Comments/VotePill.cs b/osu.Game/Overlays/Comments/VotePill.cs
index 79b7310c28..cd50546b45 100644
--- a/osu.Game/Overlays/Comments/VotePill.cs
+++ b/osu.Game/Overlays/Comments/VotePill.cs
@@ -15,6 +15,10 @@ using osu.Framework.Input.Events;
 using osu.Game.Graphics.UserInterface;
 using System.Collections.Generic;
 using osuTK;
+using osu.Game.Online.API;
+using osu.Game.Online.API.Requests;
+using osu.Framework.Bindables;
+using System.Linq;
 
 namespace osu.Game.Overlays.Comments
 {
@@ -24,26 +28,57 @@ namespace osu.Game.Overlays.Comments
 
         protected override IEnumerable<Drawable> EffectTargets => null;
 
+        [Resolved]
+        private IAPIProvider api { get; set; }
+
         private readonly Comment comment;
         private Box background;
         private Box hoverLayer;
         private CircularContainer borderContainer;
         private SpriteText sideNumber;
         private OsuSpriteText votesCounter;
+        private CommentVoteRequest request;
+
+        private readonly BindableBool isVoted = new BindableBool();
 
         public VotePill(Comment comment)
         {
             this.comment = comment;
-            votesCounter.Text = $"+{comment.VotesCount}";
+            setCount(comment.VotesCount);
+
+            Action = onAction;
 
             AutoSizeAxes = Axes.X;
             Height = 20;
             LoadingAnimationSize = new Vector2(10);
+        }
 
-            Action = () =>
-            {
+        [BackgroundDependencyLoader]
+        private void load(OsuColour colours)
+        {
+            AccentColour = borderContainer.BorderColour = sideNumber.Colour = colours.GreenLight;
+            hoverLayer.Colour = Color4.Black.Opacity(0.5f);
+        }
 
-            };
+        protected override void LoadComplete()
+        {
+            base.LoadComplete();
+            isVoted.Value = comment.IsVoted;
+            isVoted.BindValueChanged(voted => background.Colour = voted.NewValue ? AccentColour : OsuColour.Gray(0.05f), true);
+        }
+
+        private void onAction()
+        {
+            request = new CommentVoteRequest(comment.Id, isVoted.Value ? CommentVoteAction.UnVote : CommentVoteAction.Vote);
+            request.Success += onSuccess;
+            api.Queue(request);
+        }
+
+        private void onSuccess(CommentBundle response)
+        {
+            isVoted.Value = !isVoted.Value;
+            setCount(response.Comments.First().VotesCount);
+            IsLoading = false;
         }
 
         protected override Container CreateBackground() => new Container
@@ -90,46 +125,55 @@ namespace osu.Game.Overlays.Comments
             AlwaysPresent = true,
         };
 
-        [BackgroundDependencyLoader]
-        private void load(OsuColour colours)
-        {
-            AccentColour = borderContainer.BorderColour = sideNumber.Colour = colours.GreenLight;
-            background.Colour = comment.IsVoted ? AccentColour : OsuColour.Gray(0.05f);
-            hoverLayer.Colour = Color4.Black.Opacity(0.5f);
-        }
+        protected override void OnLoadingStart() => onHoverLostAction();
 
-        protected override void OnLoadingStart()
+        protected override void OnLoadingFinished()
         {
-            sideNumber.Hide();
-            borderContainer.BorderThickness = 0;
+            if (IsHovered)
+                onHoverAction();
         }
 
         protected override bool OnHover(HoverEvent e)
         {
-            if (comment.IsVoted)
-                hoverLayer.Show();
-
-            if (!IsLoading)
-            {
-                borderContainer.BorderThickness = 3;
-
-                if (!comment.IsVoted)
-                    sideNumber.Show();
-            }
-
+            onHoverAction();
             return base.OnHover(e);
         }
 
         protected override void OnHoverLost(HoverLostEvent e)
         {
+            onHoverLostAction();
             base.OnHoverLost(e);
+        }
 
-            if (comment.IsVoted)
+        private void onHoverLostAction()
+        {
+            if (isVoted.Value)
                 hoverLayer.Hide();
             else
                 sideNumber.Hide();
 
             borderContainer.BorderThickness = 0;
         }
+
+        private void onHoverAction()
+        {
+            if (!IsLoading)
+            {
+                borderContainer.BorderThickness = 3;
+
+                if (!isVoted.Value)
+                    sideNumber.Show();
+                else
+                    hoverLayer.Show();
+            }
+        }
+
+        private void setCount(int count) => votesCounter.Text = $"+{count}";
+
+        protected override void Dispose(bool isDisposing)
+        {
+            base.Dispose(isDisposing);
+            request?.Cancel();
+        }
     }
 }