sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 00:40:09 +09:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
This commit is contained in:
Dan Balasescu
2020-08-21 19:38:59 +09:00
committed by GitHub
parent aead13628b
commit 42ee9b75df
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
View File

@ -207,7 +207,7 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
}; };
// Pad the masking container to the starting position of the body piece (half-way under the head). // Pad the masking container to the starting position of the body piece (half-way under the head).
// This is required ot make the body start getting masked immediately as soon as the note is held. // This is required to make the body start getting masked immediately as soon as the note is held.
maskingContainer.Padding = new MarginPadding maskingContainer.Padding = new MarginPadding
{ {
Top = Direction.Value == ScrollingDirection.Up ? Head.Height / 2 : 0, Top = Direction.Value == ScrollingDirection.Up ? Head.Height / 2 : 0,
@ -218,13 +218,13 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
bodyPiece.Y = (Direction.Value == ScrollingDirection.Up ? 1 : -1) * Head.Height / 2; bodyPiece.Y = (Direction.Value == ScrollingDirection.Up ? 1 : -1) * Head.Height / 2;
bodyPiece.Height = DrawHeight - Head.Height / 2 + Tail.Height / 2; bodyPiece.Height = DrawHeight - Head.Height / 2 + Tail.Height / 2;
// As the note is being held, adjust the size of the fullSizeContainer. This has two effects: // As the note is being held, adjust the size of the sizing container. This has two effects:
// 1. The contained masking container will mask the body and ticks. // 1. The contained masking container will mask the body and ticks.
// 2. The head note will move along with the new "head position" in the container. // 2. The head note will move along with the new "head position" in the container.
if (Head.IsHit && releaseTime == null) if (Head.IsHit && releaseTime == null)
{ {
float heightDecrease = (float)(Math.Max(0, Time.Current - HitObject.StartTime) / HitObject.Duration); float remainingHeight = (float)(Math.Max(0, HitObject.GetEndTime() - Time.Current) / HitObject.Duration);
sizingContainer.Height = Math.Clamp(1 - heightDecrease, 0, 1); sizingContainer.Height = Math.Clamp(remainingHeight, 0, 1);
} }
} }