sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-07-02 08:49:59 +09:00
Code Issues Packages Projects Releases Wiki Activity

Apply refactorings according to reviews

Browse Source
This commit is contained in:
Dan Balasescu
2022-03-22 12:54:10 +09:00
parent 04f4e81852
commit 4630aa15cc
2 changed files with 13 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
osu.Game/Screens/OnlinePlay/Multiplayer/Match/MultiplayerReadyButton.cs
View File

@ -282,12 +282,12 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer.Match
int countReady = room.Users.Count(u => u.State == MultiplayerUserState.Ready); int countReady = room.Users.Count(u => u.State == MultiplayerUserState.Ready);
int countTotal = room.Users.Count(u => u.State != MultiplayerUserState.Spectating); int countTotal = room.Users.Count(u => u.State != MultiplayerUserState.Spectating);
string countdownText = room.Countdown == null ? string.Empty : $"Starting in {room.Countdown.EndTime - DateTimeOffset.Now:mm\\:ss}";
string countText = $"({countReady} / {countTotal} ready)"; string countText = $"({countReady} / {countTotal} ready)";
if (room.Countdown != null) if (room.Countdown != null)
{ {
string countdownText = $"Starting in {room.Countdown.EndTime - DateTimeOffset.Now:mm\\:ss}";
switch (localUser?.State) switch (localUser?.State)
{ {
default: default:
@ -329,37 +329,20 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer.Match
var localUser = multiplayerClient.LocalUser; var localUser = multiplayerClient.LocalUser;
if (room.Countdown != null) switch (localUser?.State)
{ {
switch (localUser?.State) default:
{ setGreen();
default: break;
setGreen();
break;
case MultiplayerUserState.Spectating: case MultiplayerUserState.Spectating:
case MultiplayerUserState.Ready: case MultiplayerUserState.Ready:
if (room?.Host?.Equals(localUser) == true && room.Countdown == null)
setGreen();
else
setYellow(); setYellow();
break;
}
}
else
{
switch (localUser?.State)
{
default:
setGreen();
break;
case MultiplayerUserState.Spectating: break;
case MultiplayerUserState.Ready:
if (room?.Host?.Equals(localUser) == true)
setGreen();
else
setYellow();
break;
}
} }
void setYellow() void setYellow()

8
osu.Game/Tests/Visual/Multiplayer/TestMultiplayerClient.cs
View File

@ -322,13 +322,7 @@ namespace osu.Game.Tests.Visual.Multiplayer
async Task start() async Task start()
{ {
try await lastCountdownTask;
{
await lastCountdownTask;
}
catch (OperationCanceledException)
{
}
Schedule(() => Schedule(() =>
{ {