sim1222/osukey
1
1
Fork 0
mirror of https://github.com/osukey/osukey.git synced 2025-08-05 07:33:55 +09:00
Code Issues Packages Projects Releases Wiki Activity

Add comment regarding deadlock avoidance

Browse Source
This commit is contained in:
Dean Herbert
2022-05-31 12:24:44 +09:00
parent c892aed797
commit 477e520766
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game/Tests/Visual/OnlinePlay/OnlinePlayTestScene.cs
View File

@ -83,6 +83,7 @@ namespace osu.Game.Tests.Visual.OnlinePlay
#pragma warning disable RS0030 #pragma warning disable RS0030
// We can't GetResultSafely() here (will fail with "Can't use GetResultSafely from inside an async operation."), but Wait is safe enough due to // We can't GetResultSafely() here (will fail with "Can't use GetResultSafely from inside an async operation."), but Wait is safe enough due to
// the task being a TaskCompletionSource. // the task being a TaskCompletionSource.
// Importantly, this doesn't deadlock because of the scheduler call above running inline where feasible (see the `false` argument).
return tcs.Task.Result; return tcs.Task.Result;
#pragma warning restore RS0030 #pragma warning restore RS0030
}; };