Address review comments

Now asserting instead of an if-statement, change cast from OsuStorage to MigratableStorage and make internal virtual properties protected.
This commit is contained in:
Shivam
2020-06-24 23:01:56 +02:00
parent 063503f4db
commit 47a732ef60
3 changed files with 16 additions and 17 deletions

View File

@ -14,8 +14,8 @@ namespace osu.Game.IO
/// </summary>
public abstract class MigratableStorage : WrappedStorage
{
internal virtual string[] IgnoreDirectories => Array.Empty<string>();
internal virtual string[] IgnoreFiles => Array.Empty<string>();
public virtual string[] IgnoreDirectories => Array.Empty<string>();
public virtual string[] IgnoreFiles => Array.Empty<string>();
protected MigratableStorage(Storage storage, string subPath = null)
: base(storage, subPath)

View File

@ -14,9 +14,9 @@ namespace osu.Game.IO
private readonly GameHost host;
private readonly StorageConfigManager storageConfig;
internal override string[] IgnoreDirectories => new[] { "cache" };
public override string[] IgnoreDirectories => new[] { "cache" };
internal override string[] IgnoreFiles => new[]
public override string[] IgnoreFiles => new[]
{
"framework.ini",
"storage.ini"